Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/crash/content/browser/crash_dump_manager_android.h

Issue 1447213002: Add stats to distinguish android renderer crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix for review. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/browser/crash_dump_manager_android.h
diff --git a/components/crash/content/browser/crash_dump_manager_android.h b/components/crash/content/browser/crash_dump_manager_android.h
index e3f2391efe775851903cdfa88b6617599c646109..3aca0c02a9243ce6ce26e74384d3cd969403e02e 100644
--- a/components/crash/content/browser/crash_dump_manager_android.h
+++ b/components/crash/content/browser/crash_dump_manager_android.h
@@ -48,8 +48,17 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
private:
typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
+ // This enum is used to back a UMA histogram, and must be treated as
+ // append-only.
+ enum ExitStatus {
+ EMPTY_MINIDUMP = 0,
+ VALID_MINIDUMP = 1,
+ COUNT = 2
+ };
+
static void ProcessMinidump(const base::FilePath& minidump_path,
- base::ProcessHandle pid);
+ base::ProcessHandle pid,
+ bool recordExitStatus);
// content::BrowserChildProcessObserver implementation:
void BrowserChildProcessHostDisconnected(
@@ -64,7 +73,9 @@ class CrashDumpManager : public content::BrowserChildProcessObserver,
const content::NotificationDetails& details) override;
// Called on child process exit (including crash).
- void OnChildExit(int child_process_id, base::ProcessHandle pid);
+ void OnChildExit(int child_process_id,
+ base::ProcessHandle pid,
+ bool recordExitStatus);
content::NotificationRegistrar notification_registrar_;

Powered by Google App Engine
This is Rietveld 408576698