Move DeviceMotion related classes from core/dom to modules/device_orientation.

Move DeviceMotion related classes from core/dom to modules/device_orientation.

BUG=135804
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149213

[abarth-chromium, 2013-04-24 16:32:59]

LGTM

[abarth-chromium, 2013-04-24 16:34:43]

Either in this CL or another CL, you should create a
DOMWindowDeviceOrientation.idl file to hold:

    [EnabledAtRuntime] attribute DeviceMotionEventConstructor DeviceMotionEvent;
    [EnabledAtRuntime] attribute DeviceOrientationEventConstructor
DeviceOrientationEvent;

[abarth-chromium, 2013-04-24 16:35:22]

[EnabledAtRuntime] attribute EventListener ondevicemotion;
    [EnabledAtRuntime] attribute EventListener ondeviceorientation;

These too.  :)

[timvolodine, 2013-04-24 18:57:40]

On 2013/04/24 16:35:22, abarth wrote:
> [EnabledAtRuntime] attribute EventListener ondevicemotion;
>     [EnabledAtRuntime] attribute EventListener ondeviceorientation;
> 
> These too.  :)

It seems I need to create the corresponding DOMWindowDeviceOrientation .h .cpp
files as well?
Should I make those with an empty constructor?

[abarth-chromium, 2013-04-24 19:03:14]

On 2013/04/24 18:57:40, timvolodine wrote:
> It seems I need to create the corresponding DOMWindowDeviceOrientation .h .cpp
> files as well?

Yes.

> Should I make those with an empty constructor?


You should follow the pattern used by the other files with similar names.

[timvolodine, 2013-04-25 11:01:29]

On 2013/04/24 19:03:14, abarth wrote:
> On 2013/04/24 18:57:40, timvolodine wrote:
> > It seems I need to create the corresponding DOMWindowDeviceOrientation .h
.cpp
> > files as well?
> 
> Yes.
> 
> > Should I make those with an empty constructor?
> 
> 
> You should follow the pattern used by the other files with similar names.

ok will do this in a separate CL, as this appears not as straightforward as
expected..

[commit-bot: I haz the power, 2013-04-25 12:35:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-25 12:41:18]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-25 16:15:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-25 16:21:45]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 04:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-26 04:11:47]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 10:02:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-26 10:08:31]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 11:51:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-26 11:57:27]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 13:18:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-26 13:24:18]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 15:39:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/7002

[commit-bot: I haz the power, 2013-04-26 15:45:23]

Presubmit check for 14472006-7002 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[commit-bot: I haz the power, 2013-04-26 16:44:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/14472006/28001

[commit-bot: I haz the power, 2013-04-26 16:51:07]

Presubmit check for 14472006-28001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 17 file(s).

[Peter Beverloo, 2013-04-26 17:30:04]

Committed patchset #5 manually as r149213 (presubmit successful).

[Nico, 2013-04-26 19:01:15]

what about Source/core/platform/mock/DeviceMotionClientMock.h?

(also, holy merge conflicts batman :-/)

[eseidel, 2013-04-27 05:15:56]

We'll be able to enforce includes much better soon. :)  One of us (probably me)
just needs to beat "checkdeps.py" with a case-sensitivity stick first.