[MD Extensions] Fix item sorting

chrome/test/data/webui/extensions/extension_test_util.js

Index: chrome/test/data/webui/extensions/extension_test_util.js
diff --git a/chrome/test/data/webui/extensions/extension_test_util.js b/chrome/test/data/webui/extensions/extension_test_util.js
index ccea8dfed8aef36382e994b1bbf2289df49f6c56..81f10013526829e8b6181324b7fd0b40931d15b6 100644
--- a/chrome/test/data/webui/extensions/extension_test_util.js
+++ b/chrome/test/data/webui/extensions/extension_test_util.js
@@ -46,8 +46,39 @@ cr.define('extension_test_util', function() {
       expectEquals(opt_expected, element.textContent, selector);
   }
 
+  /**
+   * Creates an ExtensionInfo object.
+   * @param {Object=} opt_properties A set of properties that will be used on
+   *     the resulting ExtensionInfo (otherwise defaults will be used).
+   * @return {chrome.developerPrivate.ExtensionInfo}
+   */
+  function createExtensionInfo(opt_properties) {
+    var id = opt_properties && opt_properties.hasOwnProperty('id') ?
+        opt_properties[id] : 'a'.repeat(32);
+    var baseUrl = 'chrome-extension://' + id + '/';
+    var data = {
+      description: 'This is an extension',
+      iconUrl: 'chrome://extension-icon/' + id + '/24/0',
+      id: id,
+      incognitoAccess: {isEnabled: true, isActive: false},
+      location: 'FROM_STORE',
+      name: 'Wonderful Extension',
+      state: 'ENABLED',
+      type: 'EXTENSION',
+      version: '2.0',
+      views: [{url: baseUrl + 'foo.html'}, {url: baseUrl + 'bar.html'}],

[michaelpg, 2015/11/18 09:08:46]

not to nitpick, but if the caller passes {url: foo}, technically data.views will
be wrong...

[Devlin, 2015/11/18 17:16:59]

It shouldn't be - views is the key on the object, and there is no url key.  So
if opt_properties contains 'url', won't it just assign an url property on the
object, but not affect the url properties of the views objects?

(Whether or not we want to worry about people passing in garbage data to
opt_properties is another question - we could limit [or assert] the copied
properties to the ones present on the base ExtensionInfo, but it seems a bit
extreme right now.  Lemme know if you feel differently.)

[michaelpg, 2015/11/18 20:01:17]

Oh, baseUrl is generated from the id -- that was what I missed.

+    }
+    if (opt_properties) {

[michaelpg, 2015/11/18 09:08:46]

Object.assign(data, opt_properties);  // even works (as a no-op) if
opt_properties is undefined

or:

return Object.assign({
  description: 'This is an extension', .....
}, opt_properties);

[Devlin, 2015/11/18 17:17:00]

Rad.  Done.

+      Object.getOwnPropertyNames(opt_properties).forEach(function(name) {
+        data[name] = opt_properties[name];
+      });
+    }
+    return data;
+  }
+
   return {
     ClickMock: ClickMock,
     testVisible: testVisible,
+    createExtensionInfo: createExtensionInfo,
   };
 });