[MD Extensions] Fix item sorting

chrome/test/data/webui/extensions/cr_extensions_browsertest.js

Index: chrome/test/data/webui/extensions/cr_extensions_browsertest.js
diff --git a/chrome/test/data/webui/extensions/cr_extensions_browsertest.js b/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
index 6bc775dba270c4858c8769f113b6c14c05a630bc..d98bf5eb56074179202dfb5c42f893b4790a57e0 100644
--- a/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
+++ b/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
@@ -38,6 +38,7 @@ CrExtensionsBrowserTest.prototype = {
     'extension_item_test.js',
     'extension_service_test.js',
     'extension_sidebar_test.js',
+    'extension_manager_test.js',
     '../mock_controller.js',
     '../../../../../ui/webui/resources/js/webui_resource_test.js',
   ]),
@@ -128,11 +129,6 @@ CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled.prototype = {
     GEN('  InstallHostedApp();');
     GEN('  InstallPlatformApp();');
   },
-
-  /** @override */
-  extraLibraries: CrExtensionsBrowserTest.prototype.extraLibraries.concat([
-    'extension_manager_test.js',
-  ]),
 };
 
 TEST_F('CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled',
@@ -140,3 +136,8 @@ TEST_F('CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled',
   extension_manager_tests.registerTests();
   mocha.grep(assert(extension_manager_tests.TestNames.SplitSections)).run();
 });
+
+TEST_F('CrExtensionsBrowserTest', 'ExtensionManagerItemOrderTest', function() {

[michaelpg, 2015/11/18 09:08:46]

confusing is

[Devlin, 2015/11/18 17:16:59]

Only if you look at the test class before what it's testing. :)  In this case,
the test class is actually an implementation detail - whether or not we want to
start with real data/items added to the list.  For this particular test, we
don't.  (We could probably restructure the other Manager test to also not need
it, but I'm not sure that's necessary right now.)  In any other type of test,
this would be accomplished by just calling the appropriate AddFooExtension()
from within the test body, but for these, those calls are made in C++, and I
think that's only doable from the testGenPreamble (correct me if I'm wrong).

But I see your point.  I've reorganized this a bit to just put all the test
classes (implementation details, in my mind) at the top, and sort more clearly
by what's being tested (item, sidebar, service, manager).  Lemme know if you
think that's okay, or if you'd prefer something else.

[michaelpg, 2015/11/18 20:01:17]

Thanks.

+  extension_manager_tests.registerTests();
+  mocha.grep(assert(extension_manager_tests.TestNames.ItemOrder)).run();
+});