[MD Extensions] Fix item sorting

chrome/browser/resources/md_extensions/service.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   'use strict';
 
   /**
-   * Compares two extensions to determine which should come first in the list.
-   * @param {chrome.developerPrivate.ExtensionInfo} a
-   * @param {chrome.developerPrivate.ExtensionInfo} b
-   * @return {number}
-   */
-  var compareExtensions = function(a, b) {
-    function compare(x, y) {
-      return x < y ? -1 : (x > y ? 1 : 0);
-    }
-    function compareLocation(x, y) {
-      if (x.location == y.location)
-        return 0;
-      if (x.location == chrome.developerPrivate.Location.UNPACKED)
-        return -1;
-      if (y.location == chrome.developerPrivate.Location.UNPACKED)
-        return 1;
-      return 0;
-    }
-    return compareLocation(a, b) ||
-           compare(a.name.toLowerCase(), b.name.toLowerCase()) ||
-           compare(a.id, b.id);
-  };
-
-  /**
    * @constructor
    * @implements {extensions.ItemDelegate}
    * @implements {extensions.SidebarDelegate}
    */
   function Service() {}
 
   Service.prototype = {
     /** @private {boolean} */
     promptIsShowing_: false,
 
     /** @param {extensions.Manager} manager */
     managerReady: function(manager) {
+      /** @private {extensions.Manager} */
       this.manager_ = manager;
+      /** @private {extensions.Sidebar} */
       this.sidebar_ = manager.sidebar;
       this.sidebar_.setDelegate(this);
       chrome.developerPrivate.onProfileStateChanged.addListener(
           this.onProfileStateChanged_.bind(this));
       chrome.developerPrivate.onItemStateChanged.addListener(
           this.onItemStateChanged_.bind(this));
       chrome.developerPrivate.getExtensionsInfo(
           {includeDisabled: true, includeTerminated: true},
           function(extensions) {
-        extensions.sort(compareExtensions);
+        /** @private {Array<chrome.developerPrivate.ExtensionInfo>} */
         this.extensions_ = extensions;
         for (let extension of extensions)
           this.manager_.addItem(extension, this);
       }.bind(this));
       chrome.developerPrivate.getProfileConfiguration(
           this.onProfileStateChanged_.bind(this));
     },
 
     /**
      * @param {chrome.developerPrivate.ProfileInfo} profileInfo
      * @private
      */
     onProfileStateChanged_: function(profileInfo) {
+      /** @private {chrome.developerPrivate.ProfileInfo} */
       this.profileInfo_ = profileInfo;
       this.sidebar_.inDevMode = profileInfo.inDeveloperMode;
       this.manager_.forEachItem(function(item) {
         item.inDevMode = profileInfo.inDeveloperMode;
       });
     },
 
     /**
      * @param {chrome.developerPrivate.EventData} eventData
      * @private
@@ skipping 18 matching lines @@
           var existing = this.manager_.getItem(eventData.extensionInfo.id);
           if (existing) {
             existing.data = eventData.extensionInfo;
           } else {
             // If there's no existing item in the list, there shouldn't be an
             // extension with the same id in the data.
             var currentIndex = this.extensions_.findIndex(function(extension) {
               return extension.id == eventData.extensionInfo.id;
             });
             assert(currentIndex == -1);
-            var newIndex = this.extensions_.findIndex(function(extension) {
-              return compareExtensions(extension,
-                                       assert(eventData.extensionInfo)) > 0;
-            });
-            newIndex = newIndex == -1 ? this.extensions_.length : newIndex;
-            this.extensions_.splice(newIndex, 0, eventData.extensionInfo);
-            this.manager_.addItem(eventData.extensionInfo, this, newIndex);
+
+            this.extensions_.push(eventData.extensionInfo);
+            this.manager_.addItem(eventData.extensionInfo, this);
           }
           break;
         case EventType.UNINSTALLED:
           var currentIndex = this.extensions_.findIndex(function(extension) {
             return extension.id == eventData.item_id;
           });
           this.extensions_.splice(currentIndex, 1);
           this.manager_.removeItem(eventData.item_id);
           break;
         default:
@@ skipping 66 matching lines @@
     /** @override */
     updateAllExtensions: function() {
       chrome.developerPrivate.autoUpdate();
     },
   };
 
   cr.addSingletonGetter(Service);
 
   return {Service: Service};
 });