[MD Extensions] Fix item sorting

chrome/test/data/webui/extensions/extension_manager_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for extension-sidebar. */
 cr.define('extension_manager_tests', function() {
   /** @enum {string} */
   var TestNames = {
     SplitSections: 'split sections',
+    ItemOrder: 'item order',
   };
 
   function registerTests() {
     suite('ExtensionManagerTest', function() {
       /** @type {extensions.Manager} */
       var manager;
 
       setup(function() {
         manager = document.querySelector('extensions-manager');
       });
@@ skipping 37 matching lines @@
         var hosted_app = findItemWithName('hosted_app');
         selector = '#' + hosted_app.data.id;
         testVisible(selector, true)
         expectTrue(!!manager.$$('#websites-list').querySelector(selector));
 
         var packaged_app = findItemWithName('Packaged App Test');
         selector = '#' + packaged_app.data.id;
         testVisible(selector, true)
         expectTrue(!!manager.$$('#websites-list').querySelector(selector));
       });
+
+      test(assert(TestNames.ItemOrder), function() {
+        var extensionsSection = manager.$['extensions-list'];
+        var service = extensions.Service.getInstance();
+        expectEquals(0, extensionsSection.children.length);
+
+        var alphaFromStore = extension_test_util.createExtensionInfo(
+            {location: 'FROM_STORE', name: 'Alpha', id: 'a'.repeat(32)});
+        manager.addItem(alphaFromStore, service);
+
+        expectEquals(1, extensionsSection.children.length);
+        expectEquals(alphaFromStore.id, extensionsSection.children[0].id);
+
+        var betaUnpacked = extension_test_util.createExtensionInfo(
+            {location: 'UNPACKED', name: 'Beta', id: 'b'.repeat(32)});
+        manager.addItem(betaUnpacked, service);
+
+        expectEquals(2, extensionsSection.children.length);
+        expectEquals(betaUnpacked.id, extensionsSection.children[0].id);
+        expectEquals(alphaFromStore.id, extensionsSection.children[1].id);
+
+        var gammaUnpacked = extension_test_util.createExtensionInfo(
+            {location: 'UNPACKED', name: 'Gamma', id: 'c'.repeat(32)});
+        manager.addItem(gammaUnpacked, service);
+
+        expectEquals(3, extensionsSection.children.length);
+        expectEquals(betaUnpacked.id, extensionsSection.children[0].id);
+        expectEquals(gammaUnpacked.id, extensionsSection.children[1].id);
+        expectEquals(alphaFromStore.id, extensionsSection.children[2].id);
+
+        var aaFromStore = extension_test_util.createExtensionInfo(
+            {location: 'FROM_STORE', name: 'AA', id: 'd'.repeat(32)});

[michaelpg, 2015/11/18 09:08:46]

would you mind also adding items like
  {location: 'FROM_STORE', name: 'Aa', id: 'f'.repeat(32)}
and
  {location: 'FROM_STORE', name: 'aA', id: 'e'.repeat(32)}

to verify the sort is case-insensitive with respect to name? (not asking for
separate expectEquals blocks for them, just add two more expectEqualses at 105)

[Devlin, 2015/11/18 17:16:59]

Done.

+        manager.addItem(aaFromStore, service);
+
+        expectEquals(4, extensionsSection.children.length);
+        expectEquals(betaUnpacked.id, extensionsSection.children[0].id);
+        expectEquals(gammaUnpacked.id, extensionsSection.children[1].id);
+        expectEquals(aaFromStore.id, extensionsSection.children[2].id);
+        expectEquals(alphaFromStore.id, extensionsSection.children[3].id);
+      });
     });
   }
 
   return {
     registerTests: registerTests,
     TestNames: TestNames,
   };
 });