[MD Extensions] Fix item sorting

chrome/test/data/webui/extensions/cr_extensions_browsertest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Settings tests. */
 
 /** @const {string} Path to source root. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 20 matching lines @@
   commandLineSwitches: [{
     switchName: 'enable-md-extensions',
   }],
 
   /** @override */
   extraLibraries: PolymerTest.getLibraries(ROOT_PATH).concat([
     'extension_test_util.js',
     'extension_item_test.js',
     'extension_service_test.js',
     'extension_sidebar_test.js',
+    'extension_manager_test.js',
     '../mock_controller.js',
     '../../../../../ui/webui/resources/js/webui_resource_test.js',
   ]),
 
   /** @override */
   typedefCppFixture: 'ExtensionSettingsUIBrowserTest',
 };
 
 TEST_F('CrExtensionsBrowserTest', 'ExtensionSidebarLayoutTest', function() {
   extension_sidebar_tests.registerTests();
   mocha.grep(assert(extension_sidebar_tests.TestNames.Layout)).run();
 });
 TEST_F('CrExtensionsBrowserTest', 'ExtensionSidebarClickHandlerTest',
        function() {
   extension_sidebar_tests.registerTests();
   mocha.grep(assert(extension_sidebar_tests.TestNames.ClickHandlers)).run();
 });
 
 function CrExtensionsBrowserTestWithInstalledExtension() {}

[michaelpg, 2015/11/18 09:08:46]

organization

 
 TEST_F('CrExtensionsBrowserTest', 'ExtensionItemNormalStateTest', function() {
   extension_item_tests.registerTests();
   var TestNames = extension_item_tests.TestNames;
   mocha.grep(assert(TestNames.ElementVisibilityNormalState)).run();
 });
 
 TEST_F('CrExtensionsBrowserTest', 'ExtensionItemDetailStateTest', function() {
   extension_item_tests.registerTests();
   var TestNames = extension_item_tests.TestNames;
   mocha.grep(assert(TestNames.ElementVisibilityDetailState)).run();
 });
 
 TEST_F('CrExtensionsBrowserTest', 'ExtensionItemDeveloperStateTest',
        function() {
   extension_item_tests.registerTests();
   var TestNames = extension_item_tests.TestNames;
   mocha.grep(assert(TestNames.ElementVisibilityDeveloperState)).run();
 });
 
 TEST_F('CrExtensionsBrowserTest', 'ExtensionItemClickableItemsTest',
        function() {
   extension_item_tests.registerTests();
   var TestNames = extension_item_tests.TestNames;
   mocha.grep(assert(TestNames.ClickableItems)).run();
 });
 
 CrExtensionsBrowserTestWithInstalledExtension.prototype = {

[michaelpg, 2015/11/18 09:08:46]

your

   __proto__: CrExtensionsBrowserTest.prototype,
 
   /** @override */
   testGenPreamble: function() {
     GEN('  InstallGoodExtension();');
     GEN('  SetAutoConfirmUninstall();');
   },
 };
 
 TEST_F('CrExtensionsBrowserTestWithInstalledExtension',
@@ skipping 23 matching lines @@
 CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled.prototype = {
   __proto__: CrExtensionsBrowserTest.prototype,
 
   /** @override */
   testGenPreamble: function() {
     GEN('  InstallGoodExtension();');
     GEN('  InstallPackagedApp();');
     GEN('  InstallHostedApp();');
     GEN('  InstallPlatformApp();');
   },
-
-  /** @override */
-  extraLibraries: CrExtensionsBrowserTest.prototype.extraLibraries.concat([
-    'extension_manager_test.js',
-  ]),
 };
 
 TEST_F('CrExtensionsBrowserTestWithMultipleExtensionTypesInstalled',
        'ExtensionManagerSplitSectionsTest', function() {
   extension_manager_tests.registerTests();
   mocha.grep(assert(extension_manager_tests.TestNames.SplitSections)).run();
 });
+
+TEST_F('CrExtensionsBrowserTest', 'ExtensionManagerItemOrderTest', function() {

[michaelpg, 2015/11/18 09:08:46]

confusing is

[Devlin, 2015/11/18 17:16:59]

Only if you look at the test class before what it's testing. :)  In this case,
the test class is actually an implementation detail - whether or not we want to
start with real data/items added to the list.  For this particular test, we
don't.  (We could probably restructure the other Manager test to also not need
it, but I'm not sure that's necessary right now.)  In any other type of test,
this would be accomplished by just calling the appropriate AddFooExtension()
from within the test body, but for these, those calls are made in C++, and I
think that's only doable from the testGenPreamble (correct me if I'm wrong).

But I see your point.  I've reorganized this a bit to just put all the test
classes (implementation details, in my mind) at the top, and sort more clearly
by what's being tested (item, sidebar, service, manager).  Lemme know if you
think that's okay, or if you'd prefer something else.

[michaelpg, 2015/11/18 20:01:17]

Thanks.

+  extension_manager_tests.registerTests();
+  mocha.grep(assert(extension_manager_tests.TestNames.ItemOrder)).run();
+});