Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1447133002: Use asm style type names and improve asm typer. (Closed)

Created:
5 years, 1 month ago by bradn
Modified:
5 years, 1 month ago
Reviewers:
titzer, aseemgarg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use asm style type names and improve asm typer. The current typing-asm mishandles the relationship between unsigned numbers and int. Restructuring and using type shortcuts that approximate asm types. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=titzer@chromium.org,aseemgarg@chromium.org LOG=N Committed: https://crrev.com/c1da268e5d4d13312d6e87ec1c8a8d436ebfce7f Cr-Commit-Position: refs/heads/master@{#32057}

Patch Set 1 #

Patch Set 2 : revise #

Total comments: 2

Patch Set 3 : revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+647 lines, -417 lines) Patch
M src/ast-expression-visitor.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/type-cache.h View 1 2 1 chunk +19 lines, -1 line 0 comments Download
M src/typing-asm.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/typing-asm.cc View 1 2 25 chunks +171 lines, -93 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 2 30 chunks +422 lines, -319 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 2 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bradn
5 years, 1 month ago (2015-11-16 20:28:34 UTC) #1
titzer
lgtm other than some cleanup. In general, should we introduce union types where there are ...
5 years, 1 month ago (2015-11-17 09:25:22 UTC) #2
bradn
https://codereview.chromium.org/1447133002/diff/20001/src/typing-asm.cc File src/typing-asm.cc (right): https://codereview.chromium.org/1447133002/diff/20001/src/typing-asm.cc#newcode466 src/typing-asm.cc:466: if (!(type->Is(cache_.kAsmSigned) || type->Is(cache_.kAsmUnsigned) || On 2015/11/17 09:25:21, titzer ...
5 years, 1 month ago (2015-11-17 19:25:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447133002/40001
5 years, 1 month ago (2015-11-17 19:25:15 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-17 19:42:08 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 19:42:36 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c1da268e5d4d13312d6e87ec1c8a8d436ebfce7f
Cr-Commit-Position: refs/heads/master@{#32057}

Powered by Google App Engine
This is Rietveld 408576698