Source/core/html/forms/TextFieldInputType.cpp - Issue 144713007: Spinner elements not to dispatch change event on hover

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 144713007: Spinner elements not to dispatch change event on hover (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: SpinButton change event trigger Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger-expected.txt ('k') | Source/core/html/shadow/SpinButtonElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/TextFieldInputType.cpp

diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp

index b7dc5cd7e552b05095da7e1d128631cfdd62a193..343720f9cad58ee8ab0821ea0f9b7019e217cb8b 100644

--- a/Source/core/html/forms/TextFieldInputType.cpp

+++ b/Source/core/html/forms/TextFieldInputType.cpp

@@ -186,7 +186,7 @@ void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChange

break;

}

- if (!input->focused())

+ if (eventBehavior == DispatchNoEvent)

input->setTextAsOfLastFormControlChangeEvent(sanitizedValue);

}

@@ -212,7 +212,6 @@ void TextFieldInputType::handleKeydownEventForSpinButton(KeyboardEvent* event)

spinButtonStepDown();

else

return;

- element().dispatchFormControlChangeEvent();

event->setDefaultHandled();

}