Spinner elements not to dispatch change event on hover

Source/core/html/shadow/SpinButtonElement.cpp

 /*
  * Copyright (C) 2006, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 29 matching lines @@
 #include "platform/scroll/ScrollbarTheme.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 inline SpinButtonElement::SpinButtonElement(Document& document, SpinButtonOwner& spinButtonOwner)
     : HTMLDivElement(document)
     , m_spinButtonOwner(&spinButtonOwner)
     , m_capturing(false)
+    , m_mouseEvent(false)
     , m_upDownState(Indeterminate)
     , m_pressStartingState(Indeterminate)
     , m_repeatingTimer(this, &SpinButtonElement::repeatingTimerFired)
 {
 }
 
 PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
 {
     RefPtr<SpinButtonElement> element = adoptRef(new SpinButtonElement(document, spinButtonOwner));
     element->setShadowPseudoId(AtomicString("-webkit-inner-spin-button", AtomicString::ConstructFromLiteral));
@@ skipping 44 matching lines @@
                     // might change the element state and we might need to
                     // cancel the repeating timer by the state change. If we
                     // started the timer after doStepAction(), we would have no
                     // chance to cancel the timer.
                     startRepeatingTimer();
                     doStepAction(m_upDownState == Up ? 1 : -1);
                 }
             }
             event->setDefaultHandled();
         }
+        m_mouseEvent = true;
     } else if (mouseEvent->type() == EventTypeNames::mouseup && mouseEvent->button() == LeftButton) {
         releaseCapture();
+        m_mouseEvent = true;
     } else if (event->type() == EventTypeNames::mousemove) {
         if (box->pixelSnappedBorderBoxRect().contains(local)) {
             if (!m_capturing) {
                 if (Frame* frame = document().frame()) {
                     frame->eventHandler().setCapturingMouseEventsNode(this);
                     m_capturing = true;
                     if (Page* page = document().page())
                         page->chrome().registerPopupOpeningObserver(this);
                 }
             }
             UpDownState oldUpDownState = m_upDownState;
             m_upDownState = (local.y() < box->height() / 2) ? Up : Down;
             if (m_upDownState != oldUpDownState)
                 renderer()->repaint();
         } else {
             releaseCapture();
             m_upDownState = Indeterminate;
         }
+        m_mouseEvent = true;

[tkent, 2014/02/04 04:57:34]

This approach doesn't work for hovering case.
1. When the pointer moves on the spin button, capturing starts, and m_mouseEvent
 is set to true.
2. When the pointer moves out from the spin button, releaseCapture() is called
with m_mouseEvent==true.

     }
 
     if (!event->defaultHandled())
         HTMLDivElement::defaultEventHandler(event);
 }
 
 void SpinButtonElement::willOpenPopup()
 {
     releaseCapture();
     m_upDownState = Indeterminate;
@@ skipping 47 matching lines @@
 void SpinButtonElement::releaseCapture()
 {
     stopRepeatingTimer();
     if (m_capturing) {
         if (Frame* frame = document().frame()) {
             frame->eventHandler().setCapturingMouseEventsNode(0);
             m_capturing = false;
             if (Page* page = document().page())
                 page->chrome().unregisterPopupOpeningObserver(this);
         }
-        if (m_spinButtonOwner)
-            m_spinButtonOwner->spinButtonDidReleaseMouseCapture();
+    }
+    if (m_spinButtonOwner && m_mouseEvent) {
+        m_spinButtonOwner->spinButtonDidReleaseMouseCapture();
+        m_mouseEvent = false;
     }
 }
 
 bool SpinButtonElement::matchesReadOnlyPseudoClass() const
 {
     return shadowHost()->matchesReadOnlyPseudoClass();
 }
 
 bool SpinButtonElement::matchesReadWritePseudoClass() const
 {
@@ skipping 38 matching lines @@
         m_upDownState = Indeterminate;
     HTMLDivElement::setHovered(flag);
 }
 
 bool SpinButtonElement::shouldRespondToMouseEvents()
 {
     return !m_spinButtonOwner || m_spinButtonOwner->shouldSpinButtonRespondToMouseEvents();
 }
 
 }