[Refactor] Kill some dead code because it is no longer possible to drag maximized windows

Kills some dead code because it is no longer possible to drag maximized windows. (https://codereview.chromium.org/80323002)

Also removes DragDetails::window_resizer which is no longer needed.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247555

[pkotwicz, 2014-01-27 00:17:03]

Oshima, PTAL

[oshima, 2014-01-28 02:21:27]

lgtm

Note that when I talked to Kuscher this morning, he said one should be able to
drag out maximized window. Since it is not working now and this is indeed dead
code, lgtm.

[pkotwicz, 2014-01-28 02:23:31]

As an aside, you can asign a bug to me to implement dragging out maximized
windows.

[commit-bot: I haz the power, 2014-01-28 18:24:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/144713003/110001

[commit-bot: I haz the power, 2014-01-28 18:24:21]

Failed to apply patch for ash/wm/toplevel_window_event_handler.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/wm/toplevel_window_event_handler.cc
  Hunk #1 FAILED at 394.
  Hunk #2 FAILED at 421.
  2 out of 2 hunks FAILED -- saving rejects to file
ash/wm/toplevel_window_event_handler.cc.rej

Patch:       ash/wm/toplevel_window_event_handler.cc
Index: ash/wm/toplevel_window_event_handler.cc
diff --git a/ash/wm/toplevel_window_event_handler.cc
b/ash/wm/toplevel_window_event_handler.cc
index
399b5c2a53e5aafd64cb49568e7382eeb193b668..a48e75de8a6dba9f9c3450593cd1ad7bad183ea5
100644
--- a/ash/wm/toplevel_window_event_handler.cc
+++ b/ash/wm/toplevel_window_event_handler.cc
@@ -394,7 +394,8 @@ aura::client::WindowMoveResult
ToplevelWindowEventHandler::RunMoveLoop(
       aura::client::GetCursorClient(root_window);
   if (cursor_client)
     cursor_client->SetCursor(ui::kCursorPointer);
-  AttemptToStartDrag(source, drag_location, HTCAPTION, move_source);
+  if (!AttemptToStartDrag(source, drag_location, HTCAPTION, move_source))
+    return aura::client::MOVE_CANCELED;
 
   in_move_loop_ = true;
   bool destroyed = false;
@@ -421,22 +422,23 @@ void
ToplevelWindowEventHandler::OnDisplayConfigurationChanging() {
   CompleteDrag(DRAG_REVERT);
 }
 
-void ToplevelWindowEventHandler::AttemptToStartDrag(
+bool ToplevelWindowEventHandler::AttemptToStartDrag(
     aura::Window* window,
     const gfx::Point& point_in_parent,
     int window_component,
     aura::client::WindowMoveSource source) {
   if (window_resizer_.get())
-    CompleteDrag(DRAG_REVERT);
+    return false;
   WindowResizer* resizer = CreateWindowResizer(window, point_in_parent,
       window_component, source).release();
   if (!resizer)
-    return;
+    return false;
 
   window_resizer_.reset(new ScopedWindowResizer(this, resizer));
 
   pre_drag_window_bounds_ = window->bounds();
   in_gesture_drag_ = (source == aura::client::WINDOW_MOVE_SOURCE_TOUCH);
+  return true;
 }
 
 void ToplevelWindowEventHandler::CompleteDrag(DragCompletionStatus status) {

[commit-bot: I haz the power, 2014-01-28 18:39:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/144713003/130001

[commit-bot: I haz the power, 2014-01-29 01:06:43]

Change committed as 247555