Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 144713003: [Refactor] Kill some dead code because it is no longer possible to drag maximized windows (Closed)

Created:
6 years, 11 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Kills some dead code because it is no longer possible to drag maximized windows. (https://codereview.chromium.org/80323002) Also removes DragDetails::window_resizer which is no longer needed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247555

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -49 lines) Patch
M ash/wm/drag_details.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/wm/drag_details.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/window_state.h View 4 chunks +3 lines, -12 lines 0 comments Download
M ash/wm/window_state.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 5 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
Oshima, PTAL
6 years, 11 months ago (2014-01-27 00:17:03 UTC) #1
oshima
lgtm Note that when I talked to Kuscher this morning, he said one should be ...
6 years, 11 months ago (2014-01-28 02:21:27 UTC) #2
pkotwicz
As an aside, you can asign a bug to me to implement dragging out maximized ...
6 years, 11 months ago (2014-01-28 02:23:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/144713003/110001
6 years, 10 months ago (2014-01-28 18:24:15 UTC) #4
commit-bot: I haz the power
Failed to apply patch for ash/wm/toplevel_window_event_handler.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-28 18:24:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/144713003/130001
6 years, 10 months ago (2014-01-28 18:39:16 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 01:06:43 UTC) #7
Message was sent while issue was closed.
Change committed as 247555

Powered by Google App Engine
This is Rietveld 408576698