Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 14471041: Implement support for Math.imul in Crankshaft. (Closed)

Created:
7 years, 8 months ago by Michael Starzinger
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement support for Math.imul in Crankshaft. R=jkummerow@chromium.org TEST=mjsunit/math-imul Committed: http://code.google.com/p/v8/source/detail?r=14450

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -2 lines) Patch
M src/hydrogen.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/math.js View 2 chunks +9 lines, -1 line 1 comment Download
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/math-imul.js View 1 chunk +148 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-26 08:38:25 UTC) #1
Michael Starzinger
Committed patchset #1 manually as r14450 (presubmit successful).
7 years, 8 months ago (2013-04-26 08:52:45 UTC) #2
Sven Panne
Small DBC how to improve this CL. https://codereview.chromium.org/14471041/diff/1/src/math.js File src/math.js (right): https://codereview.chromium.org/14471041/diff/1/src/math.js#newcode220 src/math.js:220: return %NumberImul(x, ...
7 years, 7 months ago (2013-04-29 06:36:00 UTC) #3
Michael Starzinger
7 years, 7 months ago (2013-04-29 08:54:18 UTC) #4
Message was sent while issue was closed.
Yes, as discussed offline that is an additional optimization that we can do to
get all the goodness even when Math.imul is not inlined and it avoids the
overhead of a runtime call in full codegen.

Powered by Google App Engine
This is Rietveld 408576698