Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 14471028: Tell the GC prologues to construct RetainedObjectInfos only when needed. (Closed)

Created:
7 years, 8 months ago by marja
Modified:
7 years, 8 months ago
CC:
v8-dev, Michael Starzinger
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Tell the GC prologues to construct RetainedObjectInfos only when needed. The GC prologue is called by the GC, but also by the heap snapshotter. The RetainedObjectInfos are only needed by the heap snapshotter, so it's wasteful to construct them always. (And it will be even more wasteful when Blink migrates to the new GC APIs, since after that point it no longer knows about object groups.) BUG= Committed: https://code.google.com/p/v8/source/detail?r=14439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M include/v8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
hpayer, pls review. mstarzinger ACKed this approach, but we didn't discuss naming the flag.
7 years, 8 months ago (2013-04-25 09:36:22 UTC) #1
Hannes Payer (out of office)
LGTM
7 years, 8 months ago (2013-04-25 11:47:11 UTC) #2
Hannes Payer (out of office)
7 years, 8 months ago (2013-04-25 12:08:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698