net/spdy/spdy_http_stream_spdy3_unittest.cc - Issue 14471023: Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_http_stream_spdy3_unittest.cc

Issue 14471023: Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't overload SSLSocketParams c-tor Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_http_stream_spdy3_unittest.cc

diff --git a/net/spdy/spdy_http_stream_spdy3_unittest.cc b/net/spdy/spdy_http_stream_spdy3_unittest.cc

index 8e3d85e2cce2128149cb1e9cf0be3174877f987b..23b7eee66586280b12a0c7141a0d9d80e426be5f 100644

--- a/net/spdy/spdy_http_stream_spdy3_unittest.cc

+++ b/net/spdy/spdy_http_stream_spdy3_unittest.cc

@@ -816,18 +816,14 @@ void SpdyHttpStreamSpdy3Test::TestSendCredentials(

TestCompletionCallback callback;

scoped_ptr<ClientSocketHandle> connection(new ClientSocketHandle);

SSLConfig ssl_config;

- scoped_refptr<SOCKSSocketParams> socks_params;

- scoped_refptr<HttpProxySocketParams> http_proxy_params;

- scoped_refptr<SSLSocketParams> ssl_params(

- new SSLSocketParams(transport_params_,

- socks_params,

- http_proxy_params,

- ProxyServer::SCHEME_DIRECT,

- host_port_pair,

- ssl_config,

- 0,

- false,

- false));

+ scoped_refptr<SSLSocketParams> ssl_params =

+ SSLSocketParams::CreateForDirectConnection(

+ transport_params_,

+ host_port_pair,

+ ssl_config,

+ 0,

+ false,

+ false);

EXPECT_EQ(ERR_IO_PENDING,

connection->Init(host_port_pair.ToString(),

ssl_params,

« net/socket/client_socket_pool_manager.cc ('K') | « net/socket/ssl_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_session_spdy2_unittest.cc » ('j') | no next file with comments »