Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: net/socket/ssl_client_socket_pool.h

Issue 14471023: Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: don't overload SSLSocketParams c-tor Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_pool.h
diff --git a/net/socket/ssl_client_socket_pool.h b/net/socket/ssl_client_socket_pool.h
index e6e291e43a2111ef20296b40f1f99f0327bc580b..69eb7c7852d2d83bb3826c44dfd067a1c600ca29 100644
--- a/net/socket/ssl_client_socket_pool.h
+++ b/net/socket/ssl_client_socket_pool.h
@@ -39,15 +39,31 @@ class TransportSocketParams;
class NET_EXPORT_PRIVATE SSLSocketParams
: public base::RefCounted<SSLSocketParams> {
public:
- SSLSocketParams(const scoped_refptr<TransportSocketParams>& transport_params,
- const scoped_refptr<SOCKSSocketParams>& socks_params,
- const scoped_refptr<HttpProxySocketParams>& http_proxy_params,
- ProxyServer::Scheme proxy,
- const HostPortPair& host_and_port,
- const SSLConfig& ssl_config,
- int load_flags,
- bool force_spdy_over_ssl,
- bool want_spdy_over_npn);
+ static scoped_refptr<SSLSocketParams> CreateForDirectConnection(
+ const scoped_refptr<TransportSocketParams>& transport_params,
+ const HostPortPair& host_and_port,
+ const SSLConfig& ssl_config,
+ int load_flags,
+ bool force_spdy_over_ssl,
+ bool want_spdy_over_npn);
+
+ static scoped_refptr<SSLSocketParams> CreateForHttpProxy(
+ const scoped_refptr<HttpProxySocketParams>& http_proxy_params,
+ ProxyServer::Scheme proxy,
+ const HostPortPair& host_and_port,
+ const SSLConfig& ssl_config,
+ int load_flags,
+ bool force_spdy_over_ssl,
+ bool want_spdy_over_npn);
+
+ static scoped_refptr<SSLSocketParams> CreateForSocksProxy(
+ const scoped_refptr<SOCKSSocketParams>& socks_params_,
+ ProxyServer::Scheme proxy,
+ const HostPortPair& host_and_port,
+ const SSLConfig& ssl_config,
+ int load_flags,
+ bool force_spdy_over_ssl,
+ bool want_spdy_over_npn);
const scoped_refptr<TransportSocketParams>& transport_params() {
return transport_params_;
@@ -68,6 +84,17 @@ class NET_EXPORT_PRIVATE SSLSocketParams
private:
friend class base::RefCounted<SSLSocketParams>;
+ SSLSocketParams(
+ const scoped_refptr<TransportSocketParams>& transport_params,
+ const scoped_refptr<SOCKSSocketParams>& socks_params,
+ const scoped_refptr<HttpProxySocketParams>& http_proxy_params,
+ ProxyServer::Scheme proxy,
+ const HostPortPair& host_and_port,
+ const SSLConfig& ssl_config,
+ int load_flags,
+ bool force_spdy_over_ssl,
+ bool want_spdy_over_npn,
+ bool ignore_limits);
~SSLSocketParams();
const scoped_refptr<TransportSocketParams> transport_params_;

Powered by Google App Engine
This is Rietveld 408576698