net/http/http_proxy_client_socket_pool_spdy3_unittest.cc - Issue 14471023: Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_proxy_client_socket_pool_spdy3_unittest.cc

Issue 14471023: Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: don't overload SSLSocketParams c-tor Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/http/http_proxy_client_socket_pool_spdy2_unittest.cc ('k') | net/socket/client_socket_pool.h » ('j') | net/socket/client_socket_pool_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_proxy_client_socket_pool_spdy3_unittest.cc

diff --git a/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc b/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc

index 36e5869e54e65e39f1694629607e3c00fd43f285..e59686ee18d763ebefbb694b61f0ba391d517f1e 100644

--- a/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc

+++ b/net/http/http_proxy_client_socket_pool_spdy3_unittest.cc

@@ -54,15 +54,13 @@ class HttpProxyClientSocketPoolSpdy3Test : public TestWithHttpParam {

false,

OnHostResolutionCallback())),

ignored_ssl_socket_params_(

- new SSLSocketParams(ignored_transport_socket_params_,

- NULL,

- ProxyServer::SCHEME_DIRECT,

- HostPortPair("www.google.com", 443),

- ssl_config_,

- 0,

- false,

- false)),

+ SSLSocketParams::CreateForDirectConnection(

+ ignored_transport_socket_params_,

+ HostPortPair("www.google.com", 443),

+ ssl_config_,

+ 0,

+ false,

+ false)),

tcp_histograms_("MockTCP"),

transport_socket_pool_(

kMaxSockets,

« no previous file with comments | « net/http/http_proxy_client_socket_pool_spdy2_unittest.cc ('k') | net/socket/client_socket_pool.h » ('j') | net/socket/client_socket_pool_manager.cc » ('J')