Refactor pooled socket request code to prepare for implementation of pretend-to-preconnect.

net/socket/ssl_client_socket_pool.h

Index: net/socket/ssl_client_socket_pool.h
diff --git a/net/socket/ssl_client_socket_pool.h b/net/socket/ssl_client_socket_pool.h
index e6e291e43a2111ef20296b40f1f99f0327bc580b..e1156374fe3c5f9aa93de03390aed8dd9190797a 100644
--- a/net/socket/ssl_client_socket_pool.h
+++ b/net/socket/ssl_client_socket_pool.h
@@ -49,6 +49,29 @@ class NET_EXPORT_PRIVATE SSLSocketParams
                   bool force_spdy_over_ssl,
                   bool want_spdy_over_npn);
 
+  SSLSocketParams(const scoped_refptr<TransportSocketParams>& transport_params,

[mmenke, 2013/04/29 16:15:46]

I think this is actually worse than the old code.  Using overloaded functions
obscures the fact that different constructors are being called.  The Google
style guide also discourages overloading.

If we go this route, my suggestion is to make these static functions with
different names that call into it.

e.g.:

SSLSocketParams::CreateForDirectConnection()

SSLSocketParams::CreateForHttpProxy()

SSLSocketParams::CreateForSocksProxy()



We should also make the old constructor private.

[kouhei (in TOK), 2013/04/30 01:38:33]

Made static factory methods.

+                  const HostPortPair& host_and_port,
+                  const SSLConfig& ssl_config,
+                  int load_flags,
+                  bool force_spdy_over_ssl,
+                  bool want_spdy_over_npn);
+
+  SSLSocketParams(const scoped_refptr<HttpProxySocketParams>& http_proxy_params,
+                  ProxyServer::Scheme proxy,
+                  const HostPortPair& host_and_port,
+                  const SSLConfig& ssl_config,
+                  int load_flags,
+                  bool force_spdy_over_ssl,
+                  bool want_spdy_over_npn);
+
+  SSLSocketParams(const scoped_refptr<SOCKSSocketParams>& socks_params_,
+                  ProxyServer::Scheme proxy,
+                  const HostPortPair& host_and_port,
+                  const SSLConfig& ssl_config,
+                  int load_flags,
+                  bool force_spdy_over_ssl,
+                  bool want_spdy_over_npn);
+
   const scoped_refptr<TransportSocketParams>& transport_params() {
       return transport_params_;
   }