Issue 14471012: Fix overflow check in mul-i which was missing since r14322

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14471012: Fix overflow check in mul-i which was missing since r14322 (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Fix overflow check in mul-i which was missing since r14322 Committed: http://code.google.com/p/v8/source/detail?r=14430

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -18 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-mul-canoverflow.js	View		1 chunk	+12 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

PTAL. Turns out r14322 unified a bit too much -- even when HMul has int32 ...

7 years, 8 months ago (2013-04-24 18:48:28 UTC) #1

Sven Panne

LGTM. Funny that this wasn't caught by regress-927.js...

7 years, 8 months ago (2013-04-25 06:35:51 UTC) #2

Jakob Kummerow

7 years, 8 months ago (2013-04-25 07:37:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14430 (presubmit successful).