third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl - Issue 1446963002: CREDENTIAL: Teach Fetch to handle PasswordCredential objects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl

Issue 1446963002: CREDENTIAL: Teach Fetch to handle PasswordCredential objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opaque

Patch Set: Better Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp ('K') | « third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp ('k') | third_party/WebKit/Source/modules/fetch/Body.h » ('j') | third_party/WebKit/Source/modules/fetch/Body.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 typedef (FormData or URLSearchParams) CredentialBodyType;

	6

5 [	7 [

6 RuntimeEnabled=CredentialManager,	8 RuntimeEnabled=CredentialManager,
	philipj_slow 2015/11/17 15:53:59 Can you add TypeChecking=Interface to this interfa Can you add TypeChecking=Interface to this interface, and indeed for anything that's still behind this flag? It ought to change the generated code at least somewhat. philipj_slow 2015/11/18 10:00:05 Ping. Show quoted text On 2015/11/17 15:53:59, philipj wrote: > Can you add TypeChecking=Interface to this interface, and indeed for anything > that's still behind this flag? It ought to change the generated code at least > somewhat. Ping.
7 RaisesException=Constructor,	9 RaisesException=Constructor,

8 Constructor(PasswordCredentialData data),	10 Constructor(PasswordCredentialData data),

9 Exposed=Window	11 Exposed=Window

10 ] interface PasswordCredential : Credential {	12 ] interface PasswordCredential : Credential {

11 [CallWith=ScriptState] FormData toFormData(optional FormDataOptions options) ;	13 attribute DOMString idName;

	14 attribute DOMString passwordName;

	15 attribute CredentialBodyType additionalData;

12 };	16 };

OLD	NEW