runtime/lib/typeddata.dart - Issue 14468004: Fix missing concurrency check in [].forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/typeddata.dart

Issue 14468004: Fix missing concurrency check in [].forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Added comment about iteration order of lists. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/typeddata.dart

diff --git a/runtime/lib/typeddata.dart b/runtime/lib/typeddata.dart

index 75cd3624843055d63b5d7b0e72816ba01d9b1512..c2805676c7aa5f74d06a100552704a894a778de9 100644

--- a/runtime/lib/typeddata.dart

+++ b/runtime/lib/typeddata.dart

@@ -461,8 +461,8 @@ abstract class _TypedListBase {

"Cannot remove from a non-extendable array");

}

- List toList() {

- return new List.from(this);

+ List toList({bool growable: true}) {

+ return new List.from(this, growable: growable);

}

Set toSet() {