runtime/lib/growable_array.dart - Issue 14468004: Fix missing concurrency check in [].forEach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/growable_array.dart

Issue 14468004: Fix missing concurrency check in [].forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/growable_array.dart

diff --git a/runtime/lib/growable_array.dart b/runtime/lib/growable_array.dart

index 95594b60c81805cc6ed27cfdb59a5ab4f1ac1e47..f65380b68be6a79ab7cf3a89ec1840c875679073 100644

--- a/runtime/lib/growable_array.dart

+++ b/runtime/lib/growable_array.dart

@@ -238,10 +238,10 @@ class _GrowableObjectArray<T> implements List<T> {

}

void forEach(f(T element)) {

- // TODO(srdjan): Use IterableMixinWorkaround.forEach(this, f);

- // Accessing the list directly improves DeltaBlue performance by 25%.

+ int initialLength = length;

for (int i = 0; i < length; i++) {

f(this[i]);

+ if (length != initialLength) throw new ConcurrentModificationError(this);

}