Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: runtime/lib/array.dart

Issue 14468004: Fix missing concurrency check in [].forEach. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/growable_array.dart » ('j') | runtime/lib/typeddata.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.dart
diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart
index 6e038881bc3c84926de4b35d1afdb483ce7e88ec..bb68f0b3b83c1ab79b32aaedef4741681377739e 100644
--- a/runtime/lib/array.dart
+++ b/runtime/lib/array.dart
@@ -67,7 +67,7 @@ class _ObjectArray<E> implements List<E> {
if (start < 0 || start > this.length) {
throw new RangeError.range(start, 0, this.length);
}
- if (end < 0 || end > this.length) {
+ if (end < start || end > this.length) {
throw new RangeError.range(end, start, this.length);
}
int length = end - start;
« no previous file with comments | « no previous file | runtime/lib/growable_array.dart » ('j') | runtime/lib/typeddata.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698