Remove the user gesture restriction for HTMLMediaElement::load()

Remove the user gesture restriction for HTMLMediaElement::load()

load() resets some state and invokes resource selection. Preventing
resource selection is not useful, since there are several other
unguarded ways to trigger it using plain markup or scripts.

m_loadInitiatedByUserGesture has been unused outside of load() since the
npr.org quirk was removed in r158703.

If a similar feature is needed in the future, forcing preload="none"
internally would be an alternative.

BUG=342339
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166895

[philipj_slow, 2014-02-10 12:53:50]

Patch 2, depends on https://codereview.chromium.org/130813006/

[acolwell GONE FROM CHROMIUM, 2014-02-10 21:36:54]

lgtm % comment

https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (left):

https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:636: if (m_loadInitiatedByUserGesture)
Don't we need to keep this?
if (UserGestureIndicator::processingUserGesture())
  removeBehaviorsRestrictionsAfterFirstUserGesture();

[philipj_slow, 2014-02-11 03:12:21]

https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (left):

https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:636: if (m_loadInitiatedByUserGesture)
On 2014/02/10 21:36:54, acolwell wrote:
> Don't we need to keep this?
> if (UserGestureIndicator::processingUserGesture())
>   removeBehaviorsRestrictionsAfterFirstUserGesture();

Done. Ignoring legacy compat it doesn't really make sense, but
http://foolip.org/2014/02/10/media-playback-restrictions-in-blink/demo.html
depends on it to circumvent the restrictions on play()...

[philipj_slow, 2014-02-11 03:12:55]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-02-11 03:13:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/144663006/50001

[commit-bot: I haz the power, 2014-02-11 05:19:13]

Change committed as 166895