Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 144663006: Remove the user gesture restriction for HTMLMediaElement::load() (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove the user gesture restriction for HTMLMediaElement::load() load() resets some state and invokes resource selection. Preventing resource selection is not useful, since there are several other unguarded ways to trigger it using plain markup or scripts. m_loadInitiatedByUserGesture has been unused outside of load() since the npr.org quirk was removed in r158703. If a similar feature is needed in the future, forcing preload="none" internally would be an alternative. BUG=342339 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166895

Patch Set 1 #

Total comments: 2

Patch Set 2 : keep removeBehaviorsRestrictionsAfterFirstUserGesture() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -81 lines) Patch
D LayoutTests/media/video-load-require-user-gesture.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/media/video-load-require-user-gesture-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 4 chunks +6 lines, -9 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 3 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
Patch 2, depends on https://codereview.chromium.org/130813006/
6 years, 10 months ago (2014-02-10 12:53:50 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % comment https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaElement.cpp#oldcode636 Source/core/html/HTMLMediaElement.cpp:636: if (m_loadInitiatedByUserGesture) Don't we need to ...
6 years, 10 months ago (2014-02-10 21:36:54 UTC) #2
philipj_slow
https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/144663006/diff/1/Source/core/html/HTMLMediaElement.cpp#oldcode636 Source/core/html/HTMLMediaElement.cpp:636: if (m_loadInitiatedByUserGesture) On 2014/02/10 21:36:54, acolwell wrote: > Don't ...
6 years, 10 months ago (2014-02-11 03:12:21 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-11 03:12:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/144663006/50001
6 years, 10 months ago (2014-02-11 03:13:08 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 05:19:13 UTC) #6
Message was sent while issue was closed.
Change committed as 166895

Powered by Google App Engine
This is Rietveld 408576698