Magnifier: Prevent the cursor jumping on HiDPI display.

Magnifier: Prevent the cursor jumping on HiDPI display.

Magnifier have to use RootWindow::GetRootTransform() instead of getting the transform matrix from the layer because the transform from the layer isn't DPI-unaware.

BUG=235928
TEST=manual
R=oshima@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199249

[yoshiki, 2013-04-29 17:47:59]

@sky, @oshima: Could you take a look? Thanks.

[oshima, 2013-04-30 23:03:06]

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
File ash/ash_root_window_transformer_unittest.cc (right):

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
ash/ash_root_window_transformer_unittest.cc:214: EXPECT_EQ("145,200",
Can you wait until this is landed?

https://codereview.chromium.org/14293028/

https://codereview.chromium.org/14466005/diff/1/ash/magnifier/magnification_c...
File ash/magnifier/magnification_controller.cc (right):

https://codereview.chromium.org/14466005/diff/1/ash/magnifier/magnification_c...
ash/magnifier/magnification_controller.cc:50:
gfx::ToCeiledPoint(host_location_3f.AsPointF()));
We have this rounding issue because we're converting the coordinate
back and force. For m29, I'd like to change our cursor control
code so that it controls in host coordinates and convert to Root only
when necessary (say making decision).

[oshima, 2013-05-03 09:24:26]

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
File ash/ash_root_window_transformer_unittest.cc (right):

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
ash/ash_root_window_transformer_unittest.cc:214: EXPECT_EQ("145,200",
On 2013/04/30 23:03:07, oshima wrote:
> Can you wait until this is landed?
> 
> https://codereview.chromium.org/14293028/

Its landed. can you update the patch?

[yoshiki, 2013-05-03 14:37:11]

@oshima: Thanks, PTAL. I updated magnification_controller_unittest.cc and
confirmed the ash_unittests works without error.

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
File ash/ash_root_window_transformer_unittest.cc (right):

https://codereview.chromium.org/14466005/diff/1/ash/ash_root_window_transform...
ash/ash_root_window_transformer_unittest.cc:214: EXPECT_EQ("145,200",
On 2013/05/03 09:24:26, oshima wrote:
> On 2013/04/30 23:03:07, oshima wrote:
> > Can you wait until this is landed?
> > 
> > https://codereview.chromium.org/14293028/
> 
> Its landed. can you update the patch?

Done. Thanks!

[yoshiki, 2013-05-07 02:37:38]

@oshima: ping

[oshima, 2013-05-09 00:28:22]

lgtm (sorry for delay. i was ooo)

[yoshiki, 2013-05-09 12:51:07]

@sky: Could you take an onwer look? Thanks,

[sky, 2013-05-09 16:05:49]

LGTM

[commit-bot: I haz the power, 2013-05-09 16:07:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/14466005/10001

[commit-bot: I haz the power, 2013-05-09 16:23:33]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[yoshiki, 2013-05-09 18:48:35]

Committed patchset #2 manually as r199249 (presubmit successful).