Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1446533002: Revert of Roll GYP 2c1e6cc:70fa8bb (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll GYP 2c1e6cc:70fa8bb (patchset #1 id:1 of https://codereview.chromium.org/1444643003/ ) Reason for revert: Causing grief on bots. Original issue's description: > Roll GYP 2c1e6cc:70fa8bb > > This rolls GYP to the latest commit in its repo. The primary > reason for the roll is to pick up the change to the analyzer > logic in 70fa8bb, but this picks up a few more changes along the way: > > 70fa8bb Changes semantics of analyzer > f54bd19 Adds back lookup of 'all' targets > 2dd620e Attempt again to upstream Xcode project version warning > suppression, from 1416453003 and 1430573009, and rolled back in > 1423583004. > 0f5bae1 Change CMAKE_SOURCE_DIR to CMAKE_CURRENT_LIST_DIR > > BUG=552146 > TBR=aharper@chromium.org,ilewis@google.com,dpranke@chromium.org > R=dpranke@chromium.org > > Committed: https://crrev.com/8b15a0583a53ce885f8bfeeb0f1cb8b2e617913c > Cr-Commit-Position: refs/heads/master@{#359579} TBR=aharper@chromium.org,dpranke@chromium.org,ilewis@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552146 Committed: https://crrev.com/df02a0d9ecf2f7d8ece797d9a4edf0fc8041e03d Cr-Commit-Position: refs/heads/master@{#359590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Roll GYP 2c1e6cc:70fa8bb
5 years, 1 month ago (2015-11-13 18:40:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446533002/1
5 years, 1 month ago (2015-11-13 18:42:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 18:44:17 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 18:45:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df02a0d9ecf2f7d8ece797d9a4edf0fc8041e03d
Cr-Commit-Position: refs/heads/master@{#359590}

Powered by Google App Engine
This is Rietveld 408576698