[heap] Use cancelable tasks during compaction.

[heap] Use cancelable tasks during compaction.

This way we can properly cancel them on the main thread in case they never get
scheduled by the platform.

BUG=chromium:524425
LOG=N
CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg;tryserver.v8:v8_linux_gc_stress_dbg;tryserver.v8:v8_mac_gc_stress_dbg;tryserver.v8:v8_linux64_msan_rel;tryserver.v8:v8_linux64_tsan_rel;tryserver.v8:v8_mac64_asan_rel

Committed: https://crrev.com/60e8ae51204dc753ddd183720350e4e64bab39e5
Cr-Commit-Position: refs/heads/master@{#32007}

[Michael Lippautz, 2015-11-14 02:54:04]

Description was changed from

==========
[heap] Use cancelable tasks during compaction.

This way we can properly cancel them on the main thread in case they never get
scheduled by the platform.

BUG=chromium:524425
LOG=N
==========

to

==========
[heap] Use cancelable tasks during compaction.

This way we can properly cancel them on the main thread in case they never get
scheduled by the platform.

BUG=chromium:524425
LOG=N
CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg;tryserver.v8:v8_linux_gc_stress_dbg;tryserver.v8:v8_mac_gc_stress_dbg;tryserver.v8:v8_linux64_msan_rel;tryserver.v8:v8_linux64_tsan_rel;tryserver.v8:v8_mac64_asan_rel
==========

[Michael Lippautz, 2015-11-14 02:57:46]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-14 02:57:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446523003/20001

[commit-bot: I haz the power, 2015-11-15 02:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-15 02:26:08]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2015-11-15 12:54:24]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-15 12:54:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446523003/40001

[commit-bot: I haz the power, 2015-11-15 14:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-15 14:55:11]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2015-11-16 08:08:29]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-11-16 08:08:29]

PTAL

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3227: // Try to cancel compaction tasks that have not
been run (as they might be
I didn't move this to its own function because as it looks like now there will
be only this one single caller.

[Hannes Payer (out of office), 2015-11-16 11:04:03]

On 2015/11/16 08:08:29, Michael Lippautz wrote:
> PTAL
> 
> https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.cc
> File src/heap/mark-compact.cc (right):
> 
>
https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.c...
> src/heap/mark-compact.cc:3227: // Try to cancel compaction tasks that have not
> been run (as they might be
> I didn't move this to its own function because as it looks like now there will
> be only this one single caller.

[Hannes Payer (out of office), 2015-11-16 11:06:24]

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3227: // Try to cancel compaction tasks that have not
been run (as they might be
On 2015/11/16 08:08:29, Michael Lippautz wrote:
> I didn't move this to its own function because as it looks like now there will
> be only this one single caller.

I would have preferred keeping it. It gives the code more structure.

[Michael Lippautz, 2015-11-16 11:22:34]

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1446523003/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3227: // Try to cancel compaction tasks that have not
been run (as they might be
On 2015/11/16 11:06:24, Hannes Payer wrote:
> On 2015/11/16 08:08:29, Michael Lippautz wrote:
> > I didn't move this to its own function because as it looks like now there
will
> > be only this one single caller.
> 
> I would have preferred keeping it. It gives the code more structure.

Alright, done.

[Hannes Payer (out of office), 2015-11-16 11:31:19]

lgtm

https://codereview.chromium.org/1446523003/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1446523003/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3217: CompactionTask* task =
To be in sync, we could also have a StartParallelCompaction method.

[Michael Lippautz, 2015-11-16 12:06:38]

https://codereview.chromium.org/1446523003/diff/60001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1446523003/diff/60001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:3217: CompactionTask* task =
On 2015/11/16 11:31:19, Hannes Payer wrote:
> To be in sync, we could also have a StartParallelCompaction method.

Done.

[Michael Lippautz, 2015-11-16 12:08:23]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-11-16 12:08:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1446523003/#ps80001
(title: "Added StartParallelCompaction")

[commit-bot: I haz the power, 2015-11-16 12:08:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1446523003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1446523003/80001

[commit-bot: I haz the power, 2015-11-16 13:28:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-16 13:29:29]

Patchset 5 (id:??) landed as
https://crrev.com/60e8ae51204dc753ddd183720350e4e64bab39e5
Cr-Commit-Position: refs/heads/master@{#32007}