Adding third_party/openh264 build files for encoding

third_party/openh264/testing/BUILD.gn

+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//testing/test.gni")
+import("//third_party/openh264/openh264_args.gni")
+
+if (use_openh264) {
+  test("openh264_unittests") {

[Dirk Pranke, 2015/11/21 00:48:51]

If you want this to be run on the chromium bots, it should probably depend on
//base/test:run_all_unittests as well as gtest.

This adds some scaffolding that the interface to the bots needs (reporting test
failures in a particular format, support swarming, etc.).

You will also need to actually add it to the list of tests to run on each bot,
which are more-or-less in //testing/buildbot/*.json. Let me know if you need
help with that.

If you don't want to run it on the bots (just build it), gtest-only is fine.

[hbos_chromium, 2015/11/23 09:06:13]

OK, good to know. I'll do the bot stuff in a follow-up CL.

+    sources = [
+      "h264_codec_tester.cc",
+      "h264_codec_tester.h",
+      "h264_decoder_impl.cc",
+      "h264_decoder_impl.h",
+      "h264_encoder_impl.cc",
+      "h264_encoder_impl.h",
+      "i420_utils.cc",
+      "i420_utils.h",
+      "openh264_unittests.cc",
+    ]
+    defines = [ "INCLUDE_OPENH264_UNITTESTS" ]
+    deps = [
+      "//testing/gtest:gtest",

[brettw, 2015/11/24 00:05:19]

This should just be "//testing/gtest"

[hbos_chromium, 2015/11/25 16:17:02]

Done.

+      "//third_party/openh264:openh264_encoder",
+      "//third_party/openh264:openh264_decoder",
+      "//third_party/webrtc/common_video:common_video",

[brettw, 2015/11/24 00:05:19]

This should just be ""//third_party/webrtc/common_video"

[hbos_chromium, 2015/11/25 16:17:02]

OK done, but :openh264_encoder and :openh264_decoder is fine? When you don't
include the specific target name does it automatically look for a target with
the same name as the folder?

[brettw, 2015/11/25 19:26:34]

Yes, if you omit the colon the last component is implicitly duplicated.

[hbos_chromium, 2015/11/26 12:19:24]

Acknowledged.

+    ]
+  }
+} else {
+  # When building without OpenH264 we still produce a test binary but it won't
+  # contain any tests.
+  test("openh264_unittests") {
+    sources = [
+      "openh264_unittests.cc",
+    ]
+    deps = [
+      "//testing/gtest:gtest",

[brettw, 2015/11/24 00:05:19]

Same as above.

[hbos_chromium, 2015/11/25 16:17:02]

Done.

+    ]
+  }
+}