third_party/openh264/DEPS - Issue 1446453004: Adding third_party/openh264 build files for encoding

Side by Side Diff: third_party/openh264/DEPS

Issue 1446453004: Adding third_party/openh264 build files for encoding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use_openh264 = conditional on chrome branding again Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 '+openh264',

2 '+testing',	3 '+testing',

	4 '+webrtc',
	Dirk Pranke 2015/11/23 23:07:07 what directories are you trying to include here (i what directories are you trying to include here (i.e., what are the full paths)? hbos_chromium 2015/11/25 16:17:02 third_party/openh264 testing third_party/webrtc w Show quoted text On 2015/11/23 23:07:07, Dirk Pranke wrote: > what directories are you trying to include here (i.e., what are the full paths)? third_party/openh264 testing third_party/webrtc webrtc headers do #include "webrtc/...", not #include "third_party/webrtc". If I change the DEPS file to +third_party/webrtc then presubmit fails. I did the same with third_party/openh264/testing files, #include "openh264/..." instead of #include "third_party/webrtc/..." (from the third party files' "perspective" they're not "third party" to themselves I'm thinking). Dirk Pranke 2015/11/25 20:58:58 I thought the presubmit was failing because it was Show quoted text On 2015/11/25 16:17:02, hbos_chromium wrote: > On 2015/11/23 23:07:07, Dirk Pranke wrote: > > what directories are you trying to include here (i.e., what are the full > paths)? > > third_party/openh264 > testing > third_party/webrtc > > webrtc headers do #include "webrtc/...", not #include "third_party/webrtc". > If I change the DEPS file to +third_party/webrtc then presubmit fails. > > I did the same with third_party/openh264/testing files, #include "openh264/..." > instead of #include "third_party/webrtc/..." (from the third party files' > "perspective" they're not "third party" to themselves I'm thinking). I thought the presubmit was failing because it was 'webrtc' instead of 'third_party/webrtc'. I'm not sure why it would fail if you made that change, or why it's passing now, unless brett's l-g-t-m made the check not care about non-existent directories. As long as the CQ is happy, I'm fine w/ whatever works in this regard. hbos_chromium 2015/11/26 12:19:24 Yeah not sure, but I think the presubmit looks at Show quoted text On 2015/11/25 20:58:58, Dirk Pranke wrote: > On 2015/11/25 16:17:02, hbos_chromium wrote: > > On 2015/11/23 23:07:07, Dirk Pranke wrote: > > > what directories are you trying to include here (i.e., what are the full > > paths)? > > > > third_party/openh264 > > testing > > third_party/webrtc > > > > webrtc headers do #include "webrtc/...", not #include "third_party/webrtc". > > If I change the DEPS file to +third_party/webrtc then presubmit fails. > > > > I did the same with third_party/openh264/testing files, #include > "openh264/..." > > instead of #include "third_party/webrtc/..." (from the third party files' > > "perspective" they're not "third party" to themselves I'm thinking). > > I thought the presubmit was failing because it was 'webrtc' instead of > 'third_party/webrtc'. I'm not sure why it would fail if you made that change, > or why it's passing now, unless brett's l-g-t-m made the check not > care about non-existent directories. > > As long as the CQ is happy, I'm fine w/ whatever works in this regard. > Yeah not sure, but I think the presubmit looks at the #include strings which starts with "webrtc/" so that's what you have to put in include_rules, whereas the OWNERS check interprets this as src/webrtc and not src/third_party/webrtc/, so then there are no valid owners to get lgtm from. I'll have to land this with NOPRESUBMIT=true I think...
3 ]	5 ]

OLD	NEW

« third_party/openh264/BUILD.gn ('K') | « third_party/openh264/BUILD.gn ('k') | third_party/openh264/openh264.gyp » ('j') | third_party/openh264/testing/BUILD.gn » ('J')