Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3005)

Unified Diff: base/scoped_native_library_unittest.cc

Issue 1446363003: Deleted OS_WIN and all Windows specific files from base. (Closed) Base URL: https://github.com/domokit/mojo.git@base_tests
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/run_loop.cc ('k') | base/security_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/scoped_native_library_unittest.cc
diff --git a/base/scoped_native_library_unittest.cc b/base/scoped_native_library_unittest.cc
index 035faa03f741119029ecafc278a979b30d6e53d3..06dd433e36ae994adc99f05c56a976bebd777358 100644
--- a/base/scoped_native_library_unittest.cc
+++ b/base/scoped_native_library_unittest.cc
@@ -3,10 +3,6 @@
// found in the LICENSE file.
#include "base/scoped_native_library.h"
-#if defined(OS_WIN)
-#include "base/files/file_path.h"
-#endif
-
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
@@ -14,30 +10,6 @@ namespace base {
// Tests whether or not a function pointer retrieved via ScopedNativeLibrary
// is available only in a scope.
TEST(ScopedNativeLibrary, Basic) {
-#if defined(OS_WIN)
- // Get the pointer to DirectDrawCreate() from "ddraw.dll" and verify it
- // is valid only in this scope.
- // FreeLibrary() doesn't actually unload a DLL until its reference count
- // becomes zero, i.e. function pointer is still valid if the DLL used
- // in this test is also used by another part of this executable.
- // So, this test uses "ddraw.dll", which is not used by Chrome at all but
- // installed on all versions of Windows.
- const char kFunctionName[] = "DirectDrawCreate";
- NativeLibrary native_library;
- {
- FilePath path(GetNativeLibraryName(L"ddraw"));
- native_library = LoadNativeLibrary(path, NULL);
- ScopedNativeLibrary library(native_library);
- FARPROC test_function =
- reinterpret_cast<FARPROC>(library.GetFunctionPointer(kFunctionName));
- EXPECT_EQ(0, IsBadCodePtr(test_function));
- EXPECT_EQ(
- GetFunctionPointerFromNativeLibrary(native_library, kFunctionName),
- test_function);
- }
- EXPECT_EQ(NULL,
- GetFunctionPointerFromNativeLibrary(native_library, kFunctionName));
-#endif
}
} // namespace base
« no previous file with comments | « base/run_loop.cc ('k') | base/security_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698