Index: base/path_service_unittest.cc |
diff --git a/base/path_service_unittest.cc b/base/path_service_unittest.cc |
index 7551d6764165753fdac3115a8d6c355f895dfeed..25d590afc0f1667fb3a0e6f45f69456d4c5f11e6 100644 |
--- a/base/path_service_unittest.cc |
+++ b/base/path_service_unittest.cc |
@@ -14,10 +14,6 @@ |
#include "testing/gtest/include/gtest/gtest.h" |
#include "testing/platform_test.h" |
-#if defined(OS_WIN) |
-#include "base/win/windows_version.h" |
-#endif |
- |
namespace { |
// Returns true if PathService::Get returns true and sets the path parameter |
@@ -41,13 +37,6 @@ bool ReturnsValidPath(int dir_type) { |
if (dir_type == base::DIR_USER_DESKTOP) |
check_path_exists = false; |
#endif |
-#if defined(OS_WIN) |
- if (dir_type == base::DIR_TASKBAR_PINS) { |
- // There is no pinned-to-taskbar shortcuts prior to Win7. |
- if (base::win::GetVersion() < base::win::VERSION_WIN7) |
- check_path_exists = false; |
- } |
-#endif |
#if defined(OS_MACOSX) |
if (dir_type != base::DIR_EXE && dir_type != base::DIR_MODULE && |
dir_type != base::FILE_EXE && dir_type != base::FILE_MODULE) { |
@@ -62,17 +51,6 @@ bool ReturnsValidPath(int dir_type) { |
base::PathExists(path)); |
} |
-#if defined(OS_WIN) |
-// Function to test any directory keys that are not supported on some versions |
-// of Windows. Checks that the function fails and that the returned path is |
-// empty. |
-bool ReturnsInvalidPath(int dir_type) { |
- base::FilePath path; |
- bool result = PathService::Get(dir_type, &path); |
- return !result && path.empty(); |
-} |
-#endif |
- |
} // namespace |
// On the Mac this winds up using some autoreleased objects, so we need to |
@@ -95,18 +73,7 @@ TEST_F(PathServiceTest, Get) { |
#endif |
EXPECT_PRED1(ReturnsValidPath, key); |
} |
-#if defined(OS_WIN) |
- for (int key = base::PATH_WIN_START + 1; key < base::PATH_WIN_END; ++key) { |
- bool valid = true; |
- if (key == base::DIR_APP_SHORTCUTS) |
- valid = base::win::GetVersion() >= base::win::VERSION_WIN8; |
- |
- if (valid) |
- EXPECT_TRUE(ReturnsValidPath(key)) << key; |
- else |
- EXPECT_TRUE(ReturnsInvalidPath(key)) << key; |
- } |
-#elif defined(OS_MACOSX) |
+#if defined(OS_MACOSX) |
for (int key = base::PATH_MAC_START + 1; key < base::PATH_MAC_END; ++key) { |
EXPECT_PRED1(ReturnsValidPath, key); |
} |
@@ -220,55 +187,3 @@ TEST_F(PathServiceTest, RemoveOverride) { |
EXPECT_TRUE(PathService::Get(base::DIR_TEMP, &new_user_data_dir)); |
EXPECT_EQ(original_user_data_dir, new_user_data_dir); |
} |
- |
-#if defined(OS_WIN) |
-TEST_F(PathServiceTest, GetProgramFiles) { |
- base::FilePath programfiles_dir; |
-#if defined(_WIN64) |
- // 64-bit on 64-bit. |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILESX86, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files (x86)")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES6432, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
-#else |
- if (base::win::OSInfo::GetInstance()->wow64_status() == |
- base::win::OSInfo::WOW64_ENABLED) { |
- // 32-bit on 64-bit. |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files (x86)")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILESX86, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files (x86)")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES6432, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
- } else { |
- // 32-bit on 32-bit. |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILESX86, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
- EXPECT_TRUE(PathService::Get(base::DIR_PROGRAM_FILES6432, |
- &programfiles_dir)); |
- EXPECT_EQ(programfiles_dir.value(), |
- FILE_PATH_LITERAL("C:\\Program Files")); |
- } |
-#endif |
-} |
-#endif |