Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: base/file_version_info.h

Issue 1446363003: Deleted OS_WIN and all Windows specific files from base. (Closed) Base URL: https://github.com/domokit/mojo.git@base_tests
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/event_types.h ('k') | base/file_version_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_version_info.h
diff --git a/base/file_version_info.h b/base/file_version_info.h
index 57b837c24b08e90c8a1b14ec4175160a7cea0d3e..84d665ef0d566bb1dec02e33984131279bf7e709 100644
--- a/base/file_version_info.h
+++ b/base/file_version_info.h
@@ -7,12 +7,6 @@
#include "build/build_config.h"
-#if defined(OS_WIN)
-#include <windows.h>
-// http://blogs.msdn.com/oldnewthing/archive/2004/10/25/247180.aspx
-extern "C" IMAGE_DOS_HEADER __ImageBase;
-#endif // OS_WIN
-
#include <string>
#include "base/base_export.h"
@@ -35,33 +29,17 @@ class FilePath;
class BASE_EXPORT FileVersionInfo {
public:
virtual ~FileVersionInfo() {}
-#if defined(OS_WIN) || defined(OS_MACOSX)
+#if defined(OS_MACOSX)
// Creates a FileVersionInfo for the specified path. Returns NULL if something
// goes wrong (typically the file does not exit or cannot be opened). The
// returned object should be deleted when you are done with it.
static FileVersionInfo* CreateFileVersionInfo(
const base::FilePath& file_path);
-#endif // OS_WIN || OS_MACOSX
-
-#if defined(OS_WIN)
- // Creates a FileVersionInfo for the specified module. Returns NULL in case
- // of error. The returned object should be deleted when you are done with it.
- static FileVersionInfo* CreateFileVersionInfoForModule(HMODULE module);
+#endif // OS_MACOSX
// Creates a FileVersionInfo for the current module. Returns NULL in case
// of error. The returned object should be deleted when you are done with it.
- // This function should be inlined so that the "current module" is evaluated
- // correctly, instead of being the module that contains base.
- __forceinline static FileVersionInfo*
- CreateFileVersionInfoForCurrentModule() {
- HMODULE module = reinterpret_cast<HMODULE>(&__ImageBase);
- return CreateFileVersionInfoForModule(module);
- }
-#else
- // Creates a FileVersionInfo for the current module. Returns NULL in case
- // of error. The returned object should be deleted when you are done with it.
static FileVersionInfo* CreateFileVersionInfoForCurrentModule();
-#endif // OS_WIN
// Accessors to the different version properties.
// Returns an empty string if the property is not found.
« no previous file with comments | « base/event_types.h ('k') | base/file_version_info_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698