Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1446363002: MIPS64: Improve UInt32 to Double conversion. (Closed)

Created:
5 years, 1 month ago by dusan.milosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Improve UInt32 to Double conversion. TEST= BUG= Committed: https://crrev.com/9717fff12d3fc233e556460b0921aded0045fc92 Cr-Commit-Position: refs/heads/master@{#32018}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix label naming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -49 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 3 chunks +13 lines, -41 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dusan.milosavljevic
PTAL.
5 years, 1 month ago (2015-11-16 20:10:53 UTC) #2
paul.l...
LGTM. Alan and I were just discussing this switch to use cvt_d_l() but you beat ...
5 years, 1 month ago (2015-11-16 20:26:23 UTC) #3
paul.l...
Adding Alan to cc.
5 years, 1 month ago (2015-11-16 20:29:01 UTC) #5
paul.l...
not lgtm, there's a nit in the label name. Sorry I missed this first time ...
5 years, 1 month ago (2015-11-16 20:38:30 UTC) #6
dusan.milosavljevic
https://codereview.chromium.org/1446363002/diff/1/src/mips64/macro-assembler-mips64.cc File src/mips64/macro-assembler-mips64.cc (right): https://codereview.chromium.org/1446363002/diff/1/src/mips64/macro-assembler-mips64.cc#newcode1543 src/mips64/macro-assembler-mips64.cc:1543: bind(&msb_set); On 2015/11/16 20:38:30, paul.l... wrote: > Oops, this ...
5 years, 1 month ago (2015-11-16 22:08:51 UTC) #7
paul.l...
LGTM, thanks!
5 years, 1 month ago (2015-11-16 22:35:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446363002/20001
5 years, 1 month ago (2015-11-16 22:46:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-16 23:23:54 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 23:24:23 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9717fff12d3fc233e556460b0921aded0045fc92
Cr-Commit-Position: refs/heads/master@{#32018}

Powered by Google App Engine
This is Rietveld 408576698