Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: chrome/browser/media/webrtc_browsertest_perf.cc

Issue 1446173002: Fetch goog_jitter_received stats for receive stream in WebRTC perf browser test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/webrtc_browsertest_perf.h" 5 #include "chrome/browser/media/webrtc_browsertest_perf.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/test/base/in_process_browser_test.h" 9 #include "chrome/test/base/in_process_browser_test.h"
10 #include "testing/perf/perf_test.h" 10 #include "testing/perf/perf_test.h"
(...skipping 17 matching lines...) Expand all
28 // Not an audio receive stream. 28 // Not an audio receive stream.
29 return false; 29 return false;
30 } 30 }
31 31
32 EXPECT_TRUE(pc_dict.GetString(Statistic("bytesReceived", ssrc), &value)); 32 EXPECT_TRUE(pc_dict.GetString(Statistic("bytesReceived", ssrc), &value));
33 perf_test::PrintResult( 33 perf_test::PrintResult(
34 "audio_bytes", modifier, "bytes_recv", value, "bytes", false); 34 "audio_bytes", modifier, "bytes_recv", value, "bytes", false);
35 EXPECT_TRUE(pc_dict.GetString(Statistic("packetsLost", ssrc), &value)); 35 EXPECT_TRUE(pc_dict.GetString(Statistic("packetsLost", ssrc), &value));
36 perf_test::PrintResult( 36 perf_test::PrintResult(
37 "audio_misc", modifier, "packets_lost", value, "frames", false); 37 "audio_misc", modifier, "packets_lost", value, "frames", false);
38 EXPECT_TRUE(pc_dict.GetString(Statistic("googJitterReceived", ssrc), &value));
39 perf_test::PrintResult(
40 "audio_rx", modifier, "goog_jitter_recv", value, "ms", false);
38 41
39 EXPECT_TRUE(pc_dict.GetString(Statistic("googExpandRate", ssrc), &value)); 42 EXPECT_TRUE(pc_dict.GetString(Statistic("googExpandRate", ssrc), &value));
40 perf_test::PrintResult( 43 perf_test::PrintResult(
41 "audio_rates", modifier, "goog_expand_rate", value, "%", false); 44 "audio_rates", modifier, "goog_expand_rate", value, "%", false);
42 EXPECT_TRUE( 45 EXPECT_TRUE(
43 pc_dict.GetString(Statistic("googSpeechExpandRate", ssrc), &value)); 46 pc_dict.GetString(Statistic("googSpeechExpandRate", ssrc), &value));
44 perf_test::PrintResult( 47 perf_test::PrintResult(
45 "audio_rates", modifier, "goog_speech_expand_rate", value, "%", false); 48 "audio_rates", modifier, "goog_speech_expand_rate", value, "%", false);
46 EXPECT_TRUE( 49 EXPECT_TRUE(
47 pc_dict.GetString(Statistic("googSecondaryDecodedRate", ssrc), &value)); 50 pc_dict.GetString(Statistic("googSecondaryDecodedRate", ssrc), &value));
(...skipping 11 matching lines...) Expand all
59 if (!pc_dict.GetString(Statistic("audioInputLevel", ssrc), &value)) { 62 if (!pc_dict.GetString(Statistic("audioInputLevel", ssrc), &value)) {
60 // Not an audio send stream. 63 // Not an audio send stream.
61 return false; 64 return false;
62 } 65 }
63 66
64 EXPECT_TRUE(pc_dict.GetString(Statistic("bytesSent", ssrc), &value)); 67 EXPECT_TRUE(pc_dict.GetString(Statistic("bytesSent", ssrc), &value));
65 perf_test::PrintResult( 68 perf_test::PrintResult(
66 "audio_bytes", modifier, "bytes_sent", value, "bytes", false); 69 "audio_bytes", modifier, "bytes_sent", value, "bytes", false);
67 EXPECT_TRUE(pc_dict.GetString(Statistic("googJitterReceived", ssrc), &value)); 70 EXPECT_TRUE(pc_dict.GetString(Statistic("googJitterReceived", ssrc), &value));
68 perf_test::PrintResult( 71 perf_test::PrintResult(
69 "audio_tx", modifier, "goog_jitter_recv", value, "ms", false); 72 "audio_tx", modifier, "goog_jitter_recv", value, "ms", false);
phoglund_chromium 2015/11/16 14:06:35 Then you should remove this, no?
Solis 2015/11/16 14:46:15 Nope, that's the estimated jitter for send streams
phoglund_chromium 2015/11/16 14:57:58 We should consider calling this something else tho
Solis 2015/11/16 15:03:10 It is confusing for me as well. Which is why I add
70 EXPECT_TRUE(pc_dict.GetString(Statistic("googRtt", ssrc), &value)); 73 EXPECT_TRUE(pc_dict.GetString(Statistic("googRtt", ssrc), &value));
71 perf_test::PrintResult( 74 perf_test::PrintResult(
72 "audio_tx", modifier, "goog_rtt", value, "ms", false); 75 "audio_tx", modifier, "goog_rtt", value, "ms", false);
73 return true; 76 return true;
74 } 77 }
75 78
76 static bool MaybePrintResultsForVideoSend( 79 static bool MaybePrintResultsForVideoSend(
77 const std::string& ssrc, const base::DictionaryValue& pc_dict, 80 const std::string& ssrc, const base::DictionaryValue& pc_dict,
78 const std::string& modifier) { 81 const std::string& modifier) {
79 std::string value; 82 std::string value;
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 MaybePrintResultsForAudioSend(ssrc, pc_dict, modifier) || 249 MaybePrintResultsForAudioSend(ssrc, pc_dict, modifier) ||
247 MaybePrintResultsForVideoReceive(ssrc, pc_dict, modifier) || 250 MaybePrintResultsForVideoReceive(ssrc, pc_dict, modifier) ||
248 MaybePrintResultsForVideoSend(ssrc, pc_dict, modifier); 251 MaybePrintResultsForVideoSend(ssrc, pc_dict, modifier);
249 ASSERT_TRUE(did_recognize_stream_type) << "Failed to figure out which " 252 ASSERT_TRUE(did_recognize_stream_type) << "Failed to figure out which "
250 "kind of stream SSRC " << ssrc 253 "kind of stream SSRC " << ssrc
251 << " is. "; 254 << " is. ";
252 } 255 }
253 } 256 }
254 257
255 } // namespace test 258 } // namespace test
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698