Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1446163002: Rename Encryption-Key to Crypto-Key, "key" parameter to "aesgcm128". (Closed)

Created:
5 years, 1 month ago by Peter Beverloo
Modified:
5 years, 1 month ago
CC:
chromium-reviews, Peter Beverloo, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Encryption-Key to Crypto-Key, "key" parameter to "aesgcm128". Mechanical renames to align us with draft-thomson-http-encryption-02. Beyond -02, this CL also integrates the rename from the Encryption-Key header to Crypto-Key[1], and the "key" parameter to "aesgcm128"[2]. Note that the algorithmic changes of [1] have not been implemented yet. [1] https://goo.gl/f9ktM0 [2] https://goo.gl/hX9g3C BUG=486040 Committed: https://crrev.com/471cd60ba3695e430ca3bb42baabe35485a84834 Cr-Commit-Position: refs/heads/master@{#359840}

Patch Set 1 #

Patch Set 2 : one more rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -111 lines) Patch
M components/gcm_driver/crypto/encryption_header_parsers.h View 3 chunks +10 lines, -10 lines 0 comments Download
M components/gcm_driver/crypto/encryption_header_parsers.cc View 5 chunks +19 lines, -18 lines 0 comments Download
M components/gcm_driver/crypto/encryption_header_parsers_unittest.cc View 1 7 chunks +46 lines, -44 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider.cc View 5 chunks +16 lines, -19 lines 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc View 7 chunks +15 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Peter Beverloo
5 years, 1 month ago (2015-11-16 11:46:29 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 1 month ago (2015-11-16 11:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446163002/20001
5 years, 1 month ago (2015-11-16 14:30:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-16 15:21:45 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 15:22:44 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/471cd60ba3695e430ca3bb42baabe35485a84834
Cr-Commit-Position: refs/heads/master@{#359840}

Powered by Google App Engine
This is Rietveld 408576698