Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: Source/modules/device_orientation/DeviceMotionDispatcher.cpp

Issue 14460010: Implement the Blink part of the Device Motion API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fixed re-entrancy issue Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 *
4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are
6 * met:
7 *
8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above
11 * copyright notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the
13 * distribution.
14 * * Neither the name of Google Inc. nor the names of its
15 * contributors may be used to endorse or promote products derived from
16 * this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */
30
31 #include "config.h"
32 #include "DeviceMotionDispatcher.h"
33
34 #include <public/Platform.h>
35 #include <public/WebDeviceMotionData.h>
36 #include <public/WebDeviceMotionHandler.h>
37 #include "modules/device_orientation/DeviceMotionController.h"
38 #include "modules/device_orientation/DeviceMotionData.h"
39
40 namespace WebCore {
41
42 // static
43 DeviceMotionDispatcher& DeviceMotionDispatcher::shared()
44 {
45 DEFINE_STATIC_LOCAL(DeviceMotionDispatcher, deviceMotionDispatcher, ());
46 return deviceMotionDispatcher;
47 }
48
49 DeviceMotionDispatcher::DeviceMotionDispatcher()
50 {
51 }
52
53 DeviceMotionDispatcher::~DeviceMotionDispatcher()
54 {
55 }
56
57 void DeviceMotionDispatcher::addController(DeviceMotionController* controller)
58 {
59 bool wasEmpty = m_controllers.isEmpty();
60 if (!m_controllers.contains(controller))
61 m_controllers.append(controller);
62 if (wasEmpty)
63 startListening();
64 }
65
66 void DeviceMotionDispatcher::removeController(DeviceMotionController* controller )
67 {
68 // Do not actually remove controller from the vector, instead zero them out.
69 // The zeros are removed after didChangeDeviceMotion has dispatched all even ts.
70 // This is to prevent re-entrancy case when a controller is destroyed while in the
71 // didChangeDeviceMotion method.
Peter Beverloo 2013/05/08 13:15:01 Can we test this with a layout test?
timvolodine 2013/05/09 10:08:28 I'll try to add this to the tests as abarth commen
72 size_t index = m_controllers.find(controller);
73 if (index != notFound)
74 m_controllers[index] = 0;
75 }
76
77 void DeviceMotionDispatcher::startListening()
78 {
79 if (WebKit::WebDeviceMotionHandler* handler = WebKit::Platform::current()->d eviceMotionHandler())
80 handler->startListeningToDeviceMotion(this);
81 }
82
83 void DeviceMotionDispatcher::stopListening()
84 {
85 if (WebKit::WebDeviceMotionHandler* handler = WebKit::Platform::current()->d eviceMotionHandler())
86 handler->stopListeningToDeviceMotion();
87 }
88
89 void DeviceMotionDispatcher::didChangeDeviceMotion(const WebKit::WebDeviceMotion Data& motion)
90 {
91 m_lastDeviceMotionData = PassRefPtr<WebCore::DeviceMotionData>(motion);
92 bool needsCompactify = false;
Peter Beverloo 2013/05/08 13:15:01 I'm not thrilled about the "compactify" name. Can
timvolodine 2013/05/09 10:08:28 Done.
93 for (size_t i = 0; i < m_controllers.size(); ++i) {
94 if (m_controllers[i])
95 m_controllers[i]->didChangeDeviceMotion(m_lastDeviceMotionData.get() );
96 else
97 needsCompactify = true;
98 }
99
100 if (needsCompactify)
101 compactifyControllers();
102 }
103
104 DeviceMotionData* DeviceMotionDispatcher::latestDeviceMotionData()
105 {
106 return m_lastDeviceMotionData.get();
107 }
108
109 void DeviceMotionDispatcher::compactifyControllers()
110 {
111 size_t i = 0;
112 while (i < m_controllers.size()) {
113 if (!m_controllers[i]) {
114 m_controllers[i] = m_controllers.last();
115 m_controllers.removeLast();
116 } else
117 ++i;
118 }
119
120 if (m_controllers.isEmpty())
121 stopListening();
122 }
123
124 } // namespace WebKit
Peter Beverloo 2013/05/08 13:15:01 This comment should read "namespace WebCore" now.
timvolodine 2013/05/09 10:08:28 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698