Implement the Blink part of the Device Motion API.

Source/Platform/chromium/public/WebDeviceMotionData.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebDeviceMotionData_h
+#define WebDeviceMotionData_h
+
+#if WEBKIT_IMPLEMENTATION
+namespace WTF { template <typename T> class PassRefPtr; }
+namespace WebCore { class DeviceMotionData; }
+#endif
+
+namespace WebKit {
+
+#pragma pack(push, 1)
+
+class WebDeviceMotionData {
+public:
+    WebDeviceMotionData();
+    ~WebDeviceMotionData() { }
+
+    void setAccelerationX(double);
+    void setAccelerationY(double);
+    void setAccelerationZ(double);
+
+    void setAccelerationIncludingGravityX(double);
+    void setAccelerationIncludingGravityY(double);
+    void setAccelerationIncludingGravityZ(double);
+
+    void setRotationRateAlpha(double);
+    void setRotationRateBeta(double);
+    void setRotationRateGamma(double);
+
+    void setInterval(double);
+
+    double accelerationX() const { return m_accelerationX; }
+    double accelerationY() const { return m_accelerationY; }
+    double accelerationZ() const { return m_accelerationZ; }
+
+    double accelerationIncludingGravityX() const { return m_accelerationIncludingGravityX; }
+    double accelerationIncludingGravityY() const { return m_accelerationIncludingGravityY; }
+    double accelerationIncludingGravityZ() const { return m_accelerationIncludingGravityZ; }
+
+    double rotationRateAlpha() const { return m_rotationRateAlpha; }
+    double rotationRateBeta() const { return m_rotationRateBeta; }
+    double rotationRateGamma() const { return m_rotationRateGamma; }
+
+    double interval() const { return m_interval; }
+
+    double hasAccelerationX() const { return m_hasAccelerationX; }
+    double hasAccelerationY() const { return m_hasAccelerationY; }
+    double hasAccelerationZ() const { return m_hasAccelerationZ; }
+
+    double hasAccelerationIncludingGravityX() const { return m_hasAccelerationIncludingGravityX; }
+    double hasAccelerationIncludingGravityY() const { return m_hasAccelerationIncludingGravityY; }
+    double hasAccelerationIncludingGravityZ() const { return m_hasAccelerationIncludingGravityZ; }
+
+    double hasRotationRateAlpha() const { return m_hasRotationRateAlpha; }
+    double hasRotationRateBeta() const { return m_hasRotationRateBeta; }
+    double hasRotationRateGamma() const { return m_hasRotationRateGamma; }
+
+private:
+    double m_accelerationX;
+    double m_accelerationY;
+    double m_accelerationZ;
+
+    double m_accelerationIncludingGravityX;
+    double m_accelerationIncludingGravityY;
+    double m_accelerationIncludingGravityZ;
+
+    double m_rotationRateAlpha;
+    double m_rotationRateBeta;
+    double m_rotationRateGamma;
+
+    double m_interval;
+
+    char m_hasAccelerationX : 1;
+    char m_hasAccelerationY : 1;
+    char m_hasAccelerationZ : 1;

[abarth-chromium, 2013/05/07 16:43:47]

Yes, but the ": 1" should give it the proper size in the object.  This is a
boolean variable, we should use the type bool.

[timvolodine, 2013/05/07 19:02:30]

my reasoning behind using a char instead of bool is that it is guaranteed to
have sizeof=1. As far as I understand the underlying type in bitfields is used
as a granularity parameter to reserve the underlying memory, so strictly
speaking if a bool > 1 bytes we could end up with a larger memory usage. This
should probably not have any impact in most compilers though..

+
+    char m_hasAccelerationIncludingGravityX : 1;
+    char m_hasAccelerationIncludingGravityY : 1;
+    char m_hasAccelerationIncludingGravityZ : 1;
+
+    char m_hasRotationRateAlpha : 1;
+    char m_hasRotationRateBeta : 1;
+    char m_hasRotationRateGamma : 1;
+};
+
+#if WEBKIT_IMPLEMENTATION
+COMPILE_ASSERT(sizeof(WebDeviceMotionData) == (10*8 + 2), WebDeviceMotionData_has_wrong_size);
+#endif
+
+#pragma pack(pop)
+
+} // namespace WebKit
+
+#endif // WebDeviceMotionData_h