TypedArray(length) constructor

TypedArray(length) constructor

R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=14486

[Dmitry Lomov (no reviews), 2013-04-29 15:03:28]

Another overload for TypedArray constructor

[rossberg, 2013-04-29 15:17:15]

Did you add any tests for this?

Also, it just occurred to me that there don't seem to be any tests for
array(buffer)s of size 0.

https://codereview.chromium.org/14460008/diff/1/src/typedarray.js
File src/typedarray.js (right):

https://codereview.chromium.org/14460008/diff/1/src/typedarray.js#newcode128
src/typedarray.js:128: if (%_IsConstructCall()) {
Nit: if you negate this condition, you can avoid the extra if-nesting.

[Dmitry Lomov (no reviews), 2013-04-29 15:38:35]

On 2013/04/29 15:17:15, rossberg wrote:
> Did you add any tests for this?

Yes, see tests in test/mjsunit/typedarrays.js (see this patch). 
> 
> Also, it just occurred to me that there don't seem to be any tests for
> array(buffer)s of size 0.

Ditto, but not in this patch
> 
> https://codereview.chromium.org/14460008/diff/1/src/typedarray.js
> File src/typedarray.js (right):
> 
> https://codereview.chromium.org/14460008/diff/1/src/typedarray.js#newcode128
> src/typedarray.js:128: if (%_IsConstructCall()) {
> Nit: if you negate this condition, you can avoid the extra if-nesting.

[Dmitry Lomov (no reviews), 2013-04-29 16:14:02]

I realized the tests for _typed array_ length 0 had indeed been missing. Added.

[rossberg, 2013-04-29 16:14:36]

lgtm

[Dmitry Lomov (no reviews), 2013-04-29 16:16:38]

Committed patchset #2 manually as r14486 (presubmit successful).