Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1445833003: Add an option to ignore a dirty tree to roll_dep.py (Closed)

Created:
5 years, 1 month ago by smut
Modified:
5 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an option to ignore a dirty tree to roll_dep.py BUG=554638 TBR=maruel TESTED=locally verified that two deps can be rolled Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297553

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M roll_dep.py View 4 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
smut
My use case involves rolling two dependencies that rely on one another together. I need ...
5 years, 1 month ago (2015-11-14 00:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445833003/1
5 years, 1 month ago (2015-11-14 00:28:29 UTC) #6
smut
On 2015/11/14 00:28:29, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 1 month ago (2015-11-14 00:46:27 UTC) #7
smut
Committed patchset #1 (id:1) manually as 297553.
5 years, 1 month ago (2015-11-14 00:46:43 UTC) #9
M-A Ruel
5 years, 1 month ago (2015-11-14 01:54:21 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1445833003/diff/1/roll_dep.py
File roll_dep.py (right):

https://codereview.chromium.org/1445833003/diff/1/roll_dep.py#newcode71
roll_dep.py:71: ignore_dirty_tree=False):
Remove the default value

Powered by Google App Engine
This is Rietveld 408576698