Clean up RenderLayer paintOrderLists code

Source/core/rendering/RenderLayer.cpp

Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index 9ce524d8cf3878fc427e79aa477f8fd598c5a7ce..cdd61b7c76b5b6ea6b09e9c0bd1b555ee752566e 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -52,7 +52,6 @@
 #include "HTMLNames.h"
 #include "OverflowEvent.h"
 #include "ShadowRoot.h"
-#include "StaticHashSetNodeList.h"
 #include "StylePropertySet.h"
 #include "StyleResolver.h"
 #include "WebCoreMemoryInstrumentation.h"
@@ -650,219 +649,118 @@ static inline bool isPositionedContainer(const RenderLayer* layer)
     return layer->isRootLayer() || layerRenderer->isPositioned() || layer->hasTransform();
 }
 
-enum StackingOrderDirection { FromBackground, FromForeground };
-
-// We'd like to be able to iterate through a single paint order list, but for
-// efficiency's sake, we hang onto two lists instead (namely, the pos and neg
-// z-order lists produced by CollectLayers). This function allows us to index
-// into these two lists as if they were one. It also allows us to index into
-// this virtual list either from the start or from the end (i.e., in either
-// stacking order direction).
-static const RenderLayer* getStackingOrderElementAt(const Vector<RenderLayer*>* posZOrderList, const Vector<RenderLayer*>* negZOrderList, const StackingOrderDirection direction, const size_t index)
+void RenderLayer::collectBeforePromotionZOrderList(RenderLayer* ancestorStackingContext, OwnPtr<Vector<RenderLayer*> >& posZOrderListBeforePromote, OwnPtr<Vector<RenderLayer*> >& negZOrderListBeforePromote)
 {
-    size_t negZOrderListSize = negZOrderList ? negZOrderList->size() : 0;
-
-    if (direction == FromBackground) {
-        if (index < negZOrderListSize)
-            return negZOrderList->at(index);
-
-        return posZOrderList->at(index - negZOrderListSize);
-    }
-
-    size_t posZOrderListSize = posZOrderList ? posZOrderList->size() : 0;
-
-    if (index < posZOrderListSize)
-        return posZOrderList->at(posZOrderListSize - index - 1);
-
-    return negZOrderList->at(negZOrderListSize - (index - posZOrderListSize) - 1);
-}
-
-// Compute what positive and negative z-order lists would look like before and
-// after promotion, so we can later ensure that proper stacking order is
-// preserved between the two sets of lists.
-//
-// A few examples:
-// c = currentLayer
-// - = negative z-order child of currentLayer
-// + = positive z-order child of currentLayer
-// a = positioned ancestor of currentLayer
-// x = any other RenderLayer in the list
-//
-// (a) xxxxx-----++a+++x
-// (b) xxx-----c++++++xx
-//
-//
-// Normally the current layer would be painted in the normal flow list if it
-// doesn't already appear in the positive z-order list. However, in the case
-// that the layer has a positioned ancestor, it will paint directly after the
-// positioned ancestor. In example (a), the current layer would be painted in
-// the middle of its own positive z-order children, so promoting would cause a
-// change in paint order (since a promoted layer will paint all of its positive
-// z-order children strictly after it paints itself).
-//
-// In example (b), it is ok to promote the current layer only if it does not
-// have a background. If it has a background, the background gets painted before
-// the layer's negative z-order children, so again, a promotion would cause a
-// change in paint order (causing the background to get painted after the
-// negative z-order children instead of before).
-void RenderLayer::collectBeforePromotionZOrderList(RenderLayer* ancestorStackingContext, OwnPtr<Vector<RenderLayer*> >& posZOrderListBeforePromote, OwnPtr<Vector<RenderLayer*> >& negZOrderListBeforePromote, size_t& posZOrderListSizeBeforePromote, size_t& negZOrderListSizeBeforePromote)
-{
-    // We can't use TemporaryChange<> here since m_needsCompositedScrolling and
-    // m_isNormalFlowOnly are both bitfields, so we have to do it the
-    // old-fashioned way.
+    // FIXME: TemporaryChange should support bit fields.
     bool oldNeedsCompositedScrolling = m_needsCompositedScrolling;
     bool oldIsNormalFlowOnly = m_isNormalFlowOnly;
 
-    // Set the flag on the current layer, then rebuild ancestor stacking
-    // context's lists. This way, we can see the exact effects that promoting
-    // this layer would cause.
     m_needsCompositedScrolling = false;
     m_isNormalFlowOnly = shouldBeNormalFlowOnly();
+
     ancestorStackingContext->rebuildZOrderLists(StopAtStackingContexts, posZOrderListBeforePromote, negZOrderListBeforePromote, 0);
 
     m_needsCompositedScrolling = oldNeedsCompositedScrolling;
     m_isNormalFlowOnly = oldIsNormalFlowOnly;
 
-
-    posZOrderListSizeBeforePromote = posZOrderListBeforePromote ? posZOrderListBeforePromote->size() : 0;
-    negZOrderListSizeBeforePromote = negZOrderListBeforePromote ? negZOrderListBeforePromote->size() : 0;
-
     const RenderLayer* positionedAncestor = parent();
     while (positionedAncestor && !isPositionedContainer(positionedAncestor) && !positionedAncestor->isStackingContext())
         positionedAncestor = positionedAncestor->parent();
     if (positionedAncestor && (!isPositionedContainer(positionedAncestor) || positionedAncestor->isStackingContext()))
         positionedAncestor = 0;
 
-    bool currentLayerIsInPosZOrderListBeforePromote = false;
-
-    for (size_t index = 0; index < posZOrderListSizeBeforePromote; index++) {
-        if (posZOrderListBeforePromote->at(index) == this) {
-            currentLayerIsInPosZOrderListBeforePromote = true;
-            break;
-        }
-    }
+    if (!posZOrderListBeforePromote)
+        posZOrderListBeforePromote = adoptPtr(new Vector<RenderLayer*>());
+    else if (posZOrderListBeforePromote->find(this) != notFound)
+        return;
 
-    // Insert this into the posZOrderListBeforePromote directly after the
-    // positioned ancestor, if there is one. Otherwise, add it to the very
-    // beginning.
-    //
     // The current layer will appear in the z-order lists after promotion, so
     // for a meaningful comparison, we must insert it in the z-order lists
     // before promotion if it does not appear there already.
-    if (!currentLayerIsInPosZOrderListBeforePromote) {
-        if (!positionedAncestor) {
-            if (!posZOrderListBeforePromote)
-                posZOrderListBeforePromote = adoptPtr(new Vector<RenderLayer*>());
+    if (!positionedAncestor) {
+        posZOrderListBeforePromote->prepend(this);
+        return;
+    }
 
-            posZOrderListBeforePromote->prepend(this);
-            posZOrderListSizeBeforePromote++;
-        } else {
-            for (size_t index = 0; index < posZOrderListSizeBeforePromote; index++) {
-                if (posZOrderListBeforePromote->at(index) == positionedAncestor) {
-                    posZOrderListBeforePromote->insert(index + 1, this);
-                    posZOrderListSizeBeforePromote++;
-                    break;
-                }
-            }
+    for (size_t index = 0; index < posZOrderListBeforePromote->size(); index++) {
+        if (posZOrderListBeforePromote->at(index) == positionedAncestor) {
+            posZOrderListBeforePromote->insert(index + 1, this);
+            return;
         }
     }
 }
 
-void RenderLayer::collectAfterPromotionZOrderList(RenderLayer* ancestorStackingContext, OwnPtr<Vector<RenderLayer*> >& posZOrderListAfterPromote, OwnPtr<Vector<RenderLayer*> >& negZOrderListAfterPromote, size_t& posZOrderListSizeAfterPromote, size_t& negZOrderListSizeAfterPromote)
+void RenderLayer::collectAfterPromotionZOrderList(RenderLayer* ancestorStackingContext, OwnPtr<Vector<RenderLayer*> >& posZOrderListAfterPromote, OwnPtr<Vector<RenderLayer*> >& negZOrderListAfterPromote)
 {
-    // We can't use TemporaryChange<> here since m_needsCompositedScrolling and
-    // m_isNormalFlowOnly are both bitfields, so we have to do it the
-    // old-fashioned way.
+    // FIXME: TemporaryChange should support bit fields.
     bool oldNeedsCompositedScrolling = m_needsCompositedScrolling;
     bool oldIsNormalFlowOnly = m_isNormalFlowOnly;
 
-    // Set the flag on the current layer, then rebuild ancestor stacking
-    // context's lists. This way, we can see the exact effects that promoting
-    // this layer would cause.
     m_isNormalFlowOnly = false;
     m_needsCompositedScrolling = true;
+
     ancestorStackingContext->rebuildZOrderLists(StopAtStackingContexts, posZOrderListAfterPromote, negZOrderListAfterPromote, this);
 
     m_needsCompositedScrolling = oldNeedsCompositedScrolling;
     m_isNormalFlowOnly = oldIsNormalFlowOnly;
-
-    posZOrderListSizeAfterPromote = posZOrderListAfterPromote ? posZOrderListAfterPromote->size() : 0;
-    negZOrderListSizeAfterPromote = negZOrderListAfterPromote ? negZOrderListAfterPromote->size() : 0;
 }
 
-#ifndef NDEBUG
-String RenderLayer::paintOrderListsAsText()
-{
-    OwnPtr<Vector<RenderLayer*> > posZOrderListBeforePromote;
-    OwnPtr<Vector<RenderLayer*> > negZOrderListBeforePromote;
-    OwnPtr<Vector<RenderLayer*> > posZOrderListAfterPromote;
-    OwnPtr<Vector<RenderLayer*> > negZOrderListAfterPromote;
-    size_t posZOrderListSizeBeforePromote, negZOrderListSizeBeforePromote, posZOrderListSizeAfterPromote, negZOrderListSizeAfterPromote;
-
-    RenderLayer* stackingContext = ancestorStackingContext();
-
-    if (!stackingContext)
-        return String();
-
-    collectBeforePromotionZOrderList(stackingContext, posZOrderListBeforePromote, negZOrderListBeforePromote, posZOrderListSizeBeforePromote, negZOrderListSizeBeforePromote);
-    collectAfterPromotionZOrderList(stackingContext, posZOrderListAfterPromote, negZOrderListAfterPromote, posZOrderListSizeAfterPromote, negZOrderListSizeAfterPromote);
-
-    size_t sizeBeforePromote = posZOrderListSizeBeforePromote + negZOrderListSizeBeforePromote;
-    size_t sizeAfterPromote = posZOrderListSizeAfterPromote + negZOrderListSizeAfterPromote;
-
-    TextStream ts;
-
-    ts << "Layer: " << this << " \"" << debugName() << "\", z-index: " << renderer()->style()->zIndex() << "\n";
-
-    ts << "  stacking context's paint order list BEFORE promote:\n";
-    for (size_t index = 0; index < sizeBeforePromote; index++) {
-        const RenderLayer* layerBeforePromote = getStackingOrderElementAt(posZOrderListBeforePromote.get(), negZOrderListBeforePromote.get(), FromBackground, index);
-        ts << "    " << layerBeforePromote << " \"" << layerBeforePromote->debugName() << "\", z-index: " << layerBeforePromote->renderer()->style()->zIndex() << "\n";
-    }
-
-    ts << "  stacking context's paint order list AFTER promote:\n";
-    for (size_t index = 0; index < sizeAfterPromote; index++) {
-        const RenderLayer* layerAfterPromote = getStackingOrderElementAt(posZOrderListAfterPromote.get(), negZOrderListAfterPromote.get(), FromBackground, index);
-        ts << "    " << layerAfterPromote << " \"" << layerAfterPromote->debugName() << "\", z-index: " << layerAfterPromote->renderer()->style()->zIndex() << "\n";
-    }
-
-    return ts.release();
-}
-#endif
-
-PassRefPtr<NodeList> RenderLayer::paintOrderList(PaintOrderListType type)
+// Compute what positive and negative z-order lists would look like before and
+// after promotion, so we can later ensure that proper stacking order is
+// preserved between the two sets of lists.
+//
+// A few examples:
+// c = currentLayer
+// - = negative z-order child of currentLayer
+// + = positive z-order child of currentLayer
+// a = positioned ancestor of currentLayer
+// x = any other RenderLayer in the list
+//
+// (a) xxxxx-----++a+++x
+// (b) xxx-----c++++++xx
+//
+// Normally the current layer would be painted in the normal flow list if it
+// doesn't already appear in the positive z-order list. However, in the case
+// that the layer has a positioned ancestor, it will paint directly after the
+// positioned ancestor. In example (a), the current layer would be painted in
+// the middle of its own positive z-order children, so promoting would cause a
+// change in paint order (since a promoted layer will paint all of its positive
+// z-order children strictly after it paints itself).
+//
+// In example (b), it is ok to promote the current layer only if it does not
+// have a background. If it has a background, the background gets painted before
+// the layer's negative z-order children, so again, a promotion would cause a
+// change in paint order (causing the background to get painted after the
+// negative z-order children instead of before).
+//
+void RenderLayer::computePaintOrderList(PaintOrderListType type, Vector<RefPtr<Node>>& list)

[Ian Vollick, 2013/04/26 13:28:17]

Need a space between angle braces here.

 {
     OwnPtr<Vector<RenderLayer*> > posZOrderList;
     OwnPtr<Vector<RenderLayer*> > negZOrderList;
-    size_t posZOrderListSize, negZOrderListSize;
 
     RenderLayer* stackingContext = ancestorStackingContext();
 
     if (!stackingContext)
-        return 0;
-
-    switch(type) {
-        case BeforePromote:
-            collectBeforePromotionZOrderList(stackingContext, posZOrderList, negZOrderList, posZOrderListSize, negZOrderListSize);
-            break;
-
-        case AfterPromote:
-            collectAfterPromotionZOrderList(stackingContext, posZOrderList, negZOrderList, posZOrderListSize, negZOrderListSize);
-            break;
+        return;
 
-        default:
-            return 0;
+    switch (type) {
+    case BeforePromote:
+        collectBeforePromotionZOrderList(stackingContext, posZOrderList, negZOrderList);
+        break;
+    case AfterPromote:
+        collectAfterPromotionZOrderList(stackingContext, posZOrderList, negZOrderList);
+        break;
     }
 
-    size_t size = posZOrderListSize + negZOrderListSize;
-
-    ListHashSet<RefPtr<Node> > list;
-    for (size_t index = 0; index < size; index++) {
-        const RenderLayer* layer = getStackingOrderElementAt(posZOrderList.get(), negZOrderList.get(), FromBackground, index);
-        list.add(layer->renderer()->node());
+    if (negZOrderList) {
+        for (size_t index = 0; index < negZOrderList->size(); ++index)
+            list.append(negZOrderList->at(index)->renderer()->node());
     }
 
-    return StaticHashSetNodeList::adopt(list);
+    if (posZOrderList) {
+        for (size_t index = 0; index < posZOrderList->size(); ++index)
+            list.append(posZOrderList->at(index)->renderer()->node());
+    }
 }
 
 void RenderLayer::computeRepaintRects(const RenderLayerModelObject* repaintContainer, const RenderGeometryMap* geometryMap)