Issue 1445793002: nacl-clang driver: Derive nacltools::Link from gnutools::Link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1445793002: nacl-clang driver: Derive nacltools::Link from gnutools::Link (Closed)

Created:
5 years, 1 month ago by Roland McGrath

Modified:
5 years, 1 month ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

nacl-clang driver: Derive nacltools::Link from gnutools::Link The GnuTool subclass of Tool handles enabling response-file support, which matters on Windows. Using gnutools::Link as the base class rather than just changing Tool to GnuTool seems like the cleaner solution, as it avoids the need to duplicate the other methods. Only ConstructJob actually differs from gnutools::Link. BUG=512869 TEST= toolchain trybots R=dschuff@chromium.org Committed: cf0dc7f6e6123dfa9b8834b56743315300b34e6c

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	lib/Driver/Tools.h	View		1 chunk	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Roland McGrath

Committed patchset #1 (id:1) manually as cf0dc7f6e6123dfa9b8834b56743315300b34e6c (presubmit successful).

5 years, 1 month ago (2015-11-16 18:35:22 UTC) #3

Message was sent while issue was closed.

FTR, rebased upstream as r253259

Expand Messages | Collapse Messages