build/gyp_chromium - Issue 144573004: gn/gyp: Escape \ in addition to $ and " in strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_chromium

Issue 144573004: gn/gyp: Escape \ in addition to $ and " in strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_chromium

diff --git a/build/gyp_chromium b/build/gyp_chromium

index d05204b77f2b769af4a1436a45870dcb6fbb5ba9..86b6a1731735a6d49b3fdb6718b8902c98087f30 100755

--- a/build/gyp_chromium

+++ b/build/gyp_chromium

@@ -77,8 +77,9 @@ def FormatKeyForGN(key):

def EscapeStringForGN(s):

"""Converts a string to a GN string literal."""

- # Escape $ characters which have special meaning to GN.

- return '"' + s.replace('$', '\\$').replace('"', '\\"') + '"'

+ for old, new in [('$', '\\$'), ('"', '\\"'), ('\\', '\\\\')]:

halyavin 2014/02/02 03:38:22 \->\\ must be first, otherwise you will double esc

Nico 2014/02/02 03:42:48 Done. Thanks!

+ s = s.replace(old, new)

+ return '"' + s + '"'

def ProcessGypDefinesItems(items):

« no previous file with comments | « no previous file | no next file » | no next file with comments »