gn/gyp: Escape \ in addition to $ and " in strings.

gn/gyp: Escape \ in addition to $ and " in strings.

BUG=340055
R=halyavin@google.com
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248410

[Nico, 2014-02-01 19:49:53]

Heh, looks like this breaks the android webview build, due to it relying on \
NOT getting escaped:

ERROR at the command-line "--args" settings:1:74: $ not followed by an
identifier char.
is_android_webview_build=true cpu_arch="arm" os="android" android_src="\\$(PWD)"
is_gyp=true gyp_output_dir="out"

So I suppose landing this is blocked on bug 330631, somewhat surprisingly.

[halyavin, 2014-02-02 03:38:22]

https://codereview.chromium.org/144573004/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/144573004/diff/1/build/gyp_chromium#newcode80
build/gyp_chromium:80: for old, new in [('$', '\\$'), ('"', '\\"'), ('\\',
'\\\\')]:
\->\\ must be first, otherwise you will double escape $ and ".

[Nico, 2014-02-02 03:42:48]

https://codereview.chromium.org/144573004/diff/1/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/144573004/diff/1/build/gyp_chromium#newcode80
build/gyp_chromium:80: for old, new in [('$', '\\$'), ('"', '\\"'), ('\\',
'\\\\')]:
On 2014/02/02 03:38:22, halyavin wrote:
> \->\\ must be first, otherwise you will double escape $ and ".

Done. Thanks!

[halyavin, 2014-02-02 03:44:24]

lgtm

[Nico, 2014-02-02 04:01:26]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-02 04:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-02 04:01:33]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2014-02-02 04:01:40]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 04:01:42]

CQ bit was unchecked on CL. Ignoring.

[Nico, 2014-02-02 16:08:35]

brettw: TBR; halyavin's lgtm apparently doesn't count yet.

[Nico, 2014-02-02 16:08:40]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-02-02 16:08:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/144573004/100001

[Nico, 2014-02-02 16:17:16]

Committed patchset #2 manually as r248410 (presubmit successful).

[commit-bot: I haz the power, 2014-02-02 16:17:23]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 16:17:24]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-02 16:17:25]

CQ bit was unchecked on CL. Ignoring.

[brettw, 2014-02-03 06:25:07]

lgtm