Issue 14457: * Removed rep cmpsb everywhere in irregexp-ia32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14457: * Removed rep cmpsb everywhere in irregexp-ia32 (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Removed rep-cmps{w,b} from CheckCharacters to improve performance.

Patch Set 1 #

Patch Set 2 : Changes in back-reference handling #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -63 lines)			Patch
M	src/assembler-ia32.h	View	1	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/assembler-ia32.cc	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1	3 chunks	+62 lines, -59 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View		2 chunks	+52 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-12-16 13:11:12 UTC) #2

LGTM

Does it lint?

Does it run the Mozilla tests?

http://codereview.chromium.org/14457/diff/205/8
File src/assembler-ia32.h (right):

http://codereview.chromium.org/14457/diff/205/8#newcode515
Line 515: void cmpsb();
We don't use these any more and we don't think they are a good idea, so I think
they should just go away.

Expand Messages | Collapse Messages