Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: dm/DM.cpp

Issue 1445643002: Make SkAndroidCodec support wbmp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/codec/SkAndroidCodec.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DM.cpp
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 403252b03d7e3d205d086df4dc5839dc6dd99fbc..5fd03174787e3d676f54d7fbb54599c7438cf212 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -344,20 +344,29 @@ static void push_codec_srcs(Path path) {
}
}
+ uint32_t numAndroidModes = 0;
// https://bug.skia.org/4428
+ // Only test subsets for these selected image types.
scroggo 2015/11/16 15:19:58 nit: This sentence is ambiguous - I read it as mea
static const char* const exts[] = {
"jpg", "jpeg", "png", "webp",
"JPG", "JPEG", "PNG", "WEBP",
};
- bool supported = false;
for (const char* ext : exts) {
if (path.endsWith(ext)) {
- supported = true;
+ numAndroidModes = 2;
break;
}
}
- if (!supported) {
- return;
+
+ static const char* onlyFullImageExts[] = {
+ "wbmp",
+ "WBMP",
+ };
+ for (const char* ext : onlyFullImageExts) {
+ if (path.endsWith(ext)) {
+ numAndroidModes = 1;
+ break;
+ }
}
const int sampleSizes[] = { 1, 2, 3, 4, 5, 6, 7, 8 };
@@ -368,9 +377,9 @@ static void push_codec_srcs(Path path) {
};
for (int sampleSize : sampleSizes) {
- for (AndroidCodecSrc::Mode mode : androidModes) {
+ for (uint32_t m = 0; m < numAndroidModes; m++) {
scroggo 2015/11/16 15:19:58 Now I think I see why you were tempted to go all t
msarett 2015/11/16 15:40:57 I think you could make a good argument for this.
for (uint32_t i = 0; i < numColorTypes; i++) {
- push_android_codec_src(path, mode, colorTypes[i], sampleSize);
+ push_android_codec_src(path, androidModes[m], colorTypes[i], sampleSize);
}
}
}
« no previous file with comments | « no previous file | src/codec/SkAndroidCodec.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698