Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1445603002: PPC: Fix simulation of floating point <-> integer conversion. (Closed)

Created:
5 years, 1 month ago by MTBrandyberry
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix simulation of floating point <-> integer conversion. Avoid unnecessary casts to double as this my mistakenly alter NaN bits. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/06336a7d41d23d2d630813bfe16bf72d947b77d1 Cr-Commit-Position: refs/heads/master@{#31991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M src/ppc/simulator-ppc.cc View 5 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 1 month ago (2015-11-13 15:28:41 UTC) #1
michael_dawson
On 2015/11/13 15:28:41, mtbrandyberry wrote: lgtm
5 years, 1 month ago (2015-11-13 18:28:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1445603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1445603002/1
5 years, 1 month ago (2015-11-13 18:34:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 18:57:39 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06336a7d41d23d2d630813bfe16bf72d947b77d1
Cr-Commit-Position: refs/heads/master@{#31991}

Powered by Google App Engine
This is Rietveld 408576698