Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: Source/core/scripts/InFilesCompiler.pm

Issue 14456006: Fixes to make scripts generate includes with paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/scripts/InFilesCompiler.pm
diff --git a/Source/core/scripts/InFilesCompiler.pm b/Source/core/scripts/InFilesCompiler.pm
index 451a387fa2ef8664af8877f56958b4180d67d056..abc8bfa2273c6a03fb37c766ccb9ee00a57f0241 100644
--- a/Source/core/scripts/InFilesCompiler.pm
+++ b/Source/core/scripts/InFilesCompiler.pm
@@ -37,6 +37,11 @@ require Config;
package InFilesCompiler;
+use FindBin; # locate this script
+use lib "$FindBin::Bin/../../../../../third_party/WebKit/Source/bindings/scripts"; # use the binding generator directory.
+#use lib "$FindBin::Bin/../../bindings/scripts"; # use the binding generator directory.
+use idltopath;
+
my $inputFile = "";
my $outputDir = ".";
my $defaultItemFactory;
@@ -116,6 +121,8 @@ sub license()
return "/*
* THIS FILE WAS AUTOMATICALLY GENERATED, DO NOT EDIT.
*
+ * This file was generated by the make_names.pl/InFilesCompiler.pm script.
+ *
* Copyright (C) 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -276,9 +283,10 @@ sub generateHeadersHeader()
next if defined($includedInterfaces{$interfaceName});
$includedInterfaces{$interfaceName} = 1;
+ my $includepath = idl_to_path($interfaceName);
print F "#if " . $object->conditionalStringFromAttributeValue($conditional) . "\n" if $conditional;
- print F "#include \"$interfaceName.h\"\n";
+ print F "#include \"$includepath$interfaceName.h\"\n";
print F "#include \"V8$interfaceName.h\"\n";
print F "#endif\n" if $conditional;
}

Powered by Google App Engine
This is Rietveld 408576698