GPU client side changes for GpuMemoryBuffers

gpu/command_buffer/client/gpu_memory_buffer_factory.cc

Index: gpu/command_buffer/client/gpu_memory_buffer_factory.cc
diff --git a/gpu/command_buffer/client/gpu_memory_buffer_factory.cc b/gpu/command_buffer/client/gpu_memory_buffer_factory.cc
index c0e5b9f60995db5efa330a78f3606b3c4433fd4e..77459341cabdc2b1a610abb3f6b3233324053470 100644
--- a/gpu/command_buffer/client/gpu_memory_buffer_factory.cc
+++ b/gpu/command_buffer/client/gpu_memory_buffer_factory.cc
@@ -7,12 +7,14 @@
 #include "base/logging.h"
 
 namespace gpu {
+namespace gles2 {
 
 namespace {
 GpuMemoryBuffer::Creator* g_gpu_memory_buffer_factory_ = NULL;
 }
 
 const GpuMemoryBuffer::Creator& GetProcessDefaultGpuMemoryBufferFactory() {
+  DCHECK(g_gpu_memory_buffer_factory_ != NULL);
   return *g_gpu_memory_buffer_factory_;
 }
 
@@ -22,4 +24,5 @@ void SetProcessDefaultGpuMemoryBufferFactory(
   g_gpu_memory_buffer_factory_ = new GpuMemoryBuffer::Creator(factory);

[reveman, 2013/05/08 04:23:06]

This is leaking memory.

[kaanb, 2013/05/09 05:13:13]

It's one pointer per process so we felt it was reasonable. It is being
initialized as part of static initialization of WebView.

[reveman, 2013/05/10 02:06:16]

Please move this leak into WebView by making the caller responsible for managing
the memory of g_gpu_memory_buffer_factory_ asap.

Comment with a TODO here would be appreciated.

 }
 
+}  // namespace gles2
 }  // namespace gpu