android_webview/browser/gpu_memory_buffer_factory_impl.h - Issue 14456004: GPU client side changes for GpuMemoryBuffers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/browser/gpu_memory_buffer_factory_impl.h

Issue 14456004: GPU client side changes for GpuMemoryBuffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@glapi

Patch Set: Uploading again Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « android_webview/browser/DEPS ('k') | android_webview/browser/gpu_memory_buffer_factory_impl.cc » ('j') | android_webview/browser/gpu_memory_buffer_factory_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_	5 #ifndef ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_

6 #define ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_	6 #define ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_

7	7

8 #include "base/memory/scoped_ptr.h"	8 #include "base/memory/scoped_ptr.h"

9 #include "gpu/command_buffer/client/gpu_memory_buffer.h"	9 #include "gpu/command_buffer/client/gpu_memory_buffer.h"

10	10

11 namespace android_webview {	11 namespace android_webview {

12	12

13 scoped_ptr<gpu::GpuMemoryBuffer> CreateGpuMemoryBuffer(int width, int height);	13 scoped_ptr<gpu::GpuMemoryBuffer> CreateGpuMemoryBuffer(

	14 int id, int width, int height);
	joth 2013/04/29 17:21:21 nit: buffer_id here too. and if they fit, it shou nit: buffer_id here too. and if they fit, it should be aligned with open paren. (2nd example in http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...) kaanb 2013/04/30 03:40:10 Done. Show quoted text On 2013/04/29 17:21:21, joth wrote: > nit: buffer_id here too. > > and if they fit, it should be aligned with open paren. > (2nd example in > http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...) Done.
14	15

15 } // namespace android_webview	16 } // namespace android_webview

16	17

17 #endif // ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_	18 #endif // ANDROID_WEBVIEW_BROWSER_GPU_MEMORY_BUFFER_FACTORY_IMPL_H_

OLD	NEW