GPU client side changes for GpuMemoryBuffers

gpu/command_buffer/client/gpu_memory_buffer_tracker.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_CLIENT_GPU_MEMORY_BUFFER_TRACKER_IN_PROCESS_H_

[no sievers, 2013/05/14 21:10:03]

nit: update macro name to reflect class name

[kaanb, 2013/05/14 23:37:09]

Done.

+#define GPU_COMMAND_BUFFER_CLIENT_GPU_MEMORY_BUFFER_TRACKER_IN_PROCESS_H_
+
+#include <GLES2/gl2.h>
+
+#include "../client/hash_tables.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "gles2_impl_export.h"
+
+namespace gpu {
+class GpuMemoryBuffer;
+
+namespace gles2 {
+class ImageFactory;
+
+// Tracks GPU memory buffer objects for client side of command buffer.

[no sievers, 2013/05/14 21:10:03]

nit: 'for the client side of the' or 'on the client side' or so

[kaanb, 2013/05/14 23:37:09]

Done.

+class GLES2_IMPL_EXPORT GpuMemoryBufferTracker {
+ public:
+  // Ownership of |factory| and |gl| remain with caller.

[no sievers, 2013/05/14 21:10:03]

nit: |gl| seems to be obsolete

[kaanb, 2013/05/14 23:37:09]

Done.

+  explicit GpuMemoryBufferTracker(ImageFactory* factory);
+  virtual ~GpuMemoryBufferTracker();
+
+  // Methods from GpuMemoryBufferTracker

[no sievers, 2013/05/14 21:10:03]

nit: comment is obsolete since these methods are not virtual anymore

[kaanb, 2013/05/14 23:37:09]

Done.

+  virtual GLuint CreateBuffer(
+      GLsizei width, GLsizei height, GLenum internalformat) OVERRIDE;
+  virtual GpuMemoryBuffer* GetBuffer(GLuint image_id) OVERRIDE;

[no sievers, 2013/05/14 21:10:03]

make non-virtual and remove 'override'

[kaanb, 2013/05/14 23:37:09]

Done.

+  virtual void RemoveBuffer(GLuint image_id) OVERRIDE;
+
+ private:
+  typedef gpu::hash_map<GLuint, GpuMemoryBuffer*> BufferMap;
+  BufferMap buffers_;
+  ImageFactory* factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferTracker);
+};
+
+}  // namespace gles2
+}  // namespace gpu
+
+#endif  // GPU_COMMAND_BUFFER_CLIENT_GPU_MEMORY_BUFFER_TRACKER_IN_PROCESS_H_