GPU client side changes for GpuMemoryBuffers

gpu/command_buffer/client/image_factory.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_CLIENT_IMAGE_FACTORY_H_
+#define GPU_COMMAND_BUFFER_CLIENT_IMAGE_FACTORY_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "gles2_impl_export.h"
+
+namespace gpu {
+class GpuMemoryBuffer;
+
+namespace gles2 {
+
+class GLES2_IMPL_EXPORT ImageFactory {
+ public:
+  virtual ~ImageFactory() {}
+  // Craete a GpuMemoryBuffer and makes it available to the

[reveman, 2013/05/10 02:06:16]

nit: Create

[kaanb, 2013/05/13 23:00:36]

Done.

+  // service side by inserting it to the ImageManager.
+  virtual scoped_ptr<GpuMemoryBuffer> CreateGpuMemoryBuffer(
+      int width, int height, unsigned int* image_id) = 0;
+  virtual void RemoveFromManager(unsigned int image_id) = 0;

[reveman, 2013/05/10 02:06:16]

I prefer DeleteGpuMemoryBuffer(unsigned image_id). The "Delete" prefix as that's
consistent with BrowserGpuChannelHostFactory and GpuChannel. The idea that
there's an image manager for which something is inserted/removed is an
implementation detail that I don't think this API should expose.

[kaanb, 2013/05/13 23:00:36]

Done.

+};
+
+}  // namespace gles2
+}  // namespace gpu
+
+#endif  // GPU_COMMAND_BUFFER_CLIENT_IMAGE_FACTORY_H_